Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add napari-J recipe #17914

Merged
merged 10 commits into from
Feb 11, 2022
Merged

Add napari-J recipe #17914

merged 10 commits into from
Feb 11, 2022

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Feb 2, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@goanpeca
Copy link
Member Author

goanpeca commented Feb 2, 2022

We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be automatically open, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the @conda-forge/napari team will be available to help as needed.

You can read a bit more about conda-forge at https://conda-forge.org/#contribute


@volker-baecker, do you agree with being added as a maintainer?

@conda-forge-linter

This comment has been minimized.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-J) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/napari-J:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@goanpeca
Copy link
Member Author

goanpeca commented Feb 8, 2022

Haven't heard from the author. Removing from the maintainers list. We can add them when the feedstock is created if they agree by then.

@goanpeca goanpeca marked this pull request as ready for review February 8, 2022 14:59
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-J) and found it was in an excellent condition.

@jaimergp
Copy link
Member

This is a bit weird. It looks like this package distributes two projects: napari-j and ijpb (which seems to stand for ImageJ Python Bridge):

  adding 'ijpb/__init__.py'
  adding 'ijpb/func.py'
  adding 'ijpb/fiji/IPythonProxy.py'
  adding 'ijpb/fiji/__init__.py'
  adding 'napari_j/__init__.py'
  adding 'napari_j/_dock_widget.py'
  adding 'napari_j/bridge.py'
  adding 'napari_j/surfaces.py'
  adding 'napari_j/_tests/__init__.py'
  adding 'napari_j/_tests/test_dock_widget.py'
  adding 'napari_J-0.2.2.dist-info/LICENSE'
  adding 'napari_J-0.2.2.dist-info/METADATA'
  adding 'napari_J-0.2.2.dist-info/WHEEL'
  adding 'napari_J-0.2.2.dist-info/entry_points.txt'
  adding 'napari_J-0.2.2.dist-info/top_level.txt'
  adding 'napari_J-0.2.2.dist-info/RECORD'

Both projects seem to be from the same authors, but ideally we should have two conda packages as well, and make them depend on each other.

I would love to hear from @volker-baecker before making any decisions though.

@jaimergp jaimergp merged commit a467ffa into conda-forge:main Feb 11, 2022
@goanpeca goanpeca deleted the add-napari-j branch February 11, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants