Add soxr recipe #17935

HosameldinMohamed · 2022-02-03T22:14:12Z

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
License file is packaged (see here for an example).
Source is from official source.
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
If static libraries are linked in, the license of the static library is packaged.
Build number is 0.
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-linter · 2022-02-03T22:14:26Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

The home item is expected in the about section.
The recipe must have some tests.
There are too few lines. There should be one empty line at the end of the file.
license_file entry is missing, but is required.

For recipes/soxr:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter · 2022-03-22T18:37:42Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

The home item is expected in the about section.
The recipe must have some tests.
license_file entry is missing, but is required.

conda-forge-linter · 2022-03-22T18:41:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

The home item is expected in the about section.
The recipe must have some tests.

conda-forge-linter · 2022-03-22T18:55:29Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

The recipe must have some tests.

conda-forge-linter · 2022-03-22T23:30:35Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found it was in an excellent condition.

conda-forge-linter · 2022-03-23T00:30:39Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

The top level meta key host is unexpected

conda-forge-linter · 2022-03-23T00:34:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found it was in an excellent condition.

HosameldinMohamed · 2022-03-23T00:48:45Z

Enabled OpenMP on linux and macOS by adding the libgomp and llvm-openmp packages to the build section of the meta.yaml file

https://conda-forge.org/docs/maintainer/knowledge_base.html#openmp

conda-forge-linter · 2022-03-23T01:22:14Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/focal-stats) and found some lint.

Here's what I've got...

For recipes/focal-stats:

Feedstock with the same name exists in conda-forge.

conda-forge-linter · 2022-03-23T01:34:14Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found it was in an excellent condition.

HosameldinMohamed · 2022-03-23T13:08:21Z

It fails because it doesn't find the LICENSE file.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=479682&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=1537

In meta.yaml I put

  license_file: ${PREFIX}/share/doc/libsoxr/LICENCE

Because I saw the LICENSE file is installed in <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/LICENCE

HosameldinMohamed · 2022-03-23T13:12:04Z

Same problem is related to the test files, here are the files I need to test: (for linux)

    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/README  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/LICENCE  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/NEWS  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr.so.0.1.2  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr.so.0  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr.so  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/include/soxr.h  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr-lsr.so.0.1.9  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr-lsr.so.0  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/lib/libsoxr-lsr.so  # [linux]
    - test -f <CMAKE_INSTALL_PREFIX>/include/soxr-lsr.h  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/1-single-block.c  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/1a-lsr.c  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/2-stream.C  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/3-options-input-fn.c  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/4-split-channels.c  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/5-variable-rate.c  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/examples-common.h  # [not win]
    - test -f <CMAKE_INSTALL_PREFIX>/share/doc/libsoxr/examples/README  # [not win]

conda-forge-linter · 2022-03-23T16:07:50Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found it was in an excellent condition.

HosameldinMohamed · 2022-03-24T11:38:15Z

Just FYI you can also use Ninja on Windows for uniformity.

At the end I compiled Windows and non-windows with make.

HosameldinMohamed · 2022-03-24T12:09:52Z

@conda-forge/staged-recipes, ready for review, thanks.

traversaro · 2022-03-24T12:23:43Z

@conda-forge/staged-recipes, ready for review, thanks.

You are a new user so you can't mention, I will give a first round of review and then mention it for you.

recipes/soxr/bld.bat

recipes/soxr/build.sh

recipes/soxr/meta.yaml

HosameldinMohamed · 2022-03-24T13:23:16Z

@traversaro I addressed your comments!

traversaro · 2022-03-24T13:31:49Z

Thanks!

https://github.com/orgs/conda-forge/teams/staged-recipes @conda-forge/help-c-cpp The recipe is ready for review.

carterbox

Conda thinks that you aren't dynamically linking against tinyxml or libstdcxx-ng/libcxx/vsruntime for each of the three builds. Is that the case? It doesn't seem like tinyxml is a header-only library, so conda should be able to detect the links, and you shouldn't be statically linking to tinyxml. The runtime libraries you can add to the ignore_run_exports section because you may not be using the standard libraries.

recipes/soxr/meta.yaml

`not win` -> `unix` Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>

conda-forge-linter · 2022-04-07T15:24:26Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found some lint.

Here's what I've got...

For recipes/soxr:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter · 2022-04-07T15:42:34Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/soxr) and found it was in an excellent condition.

HosameldinMohamed · 2022-04-07T16:59:46Z

Conda thinks that you aren't dynamically linking against tinyxml or libstdcxx-ng/libcxx/vsruntime for each of the three builds. Is that the case? It doesn't seem like tinyxml is a header-only library, so conda should be able to detect the links, and you shouldn't be statically linking to tinyxml. The runtime libraries you can add to the ignore_run_exports section because you may not be using the standard libraries.

Thanks @carterbox for your checks.

I added

  ignore_run_exports:
    - libstdc++

But the warning is still persisting, I'll try to ignore the correct package.

I also realized that tinyxml is not required at all! My bad!

@traversaro

carterbox · 2022-04-07T17:23:57Z

  ignore_run_exports_from:
    - {{ compiler('cxx') }}

I recently learned about ignore_run_exports_from. You could try that. It may be more robust.

isuruf · 2022-04-07T17:32:23Z

Why not remove the C++ compiler from build instead?

traversaro · 2022-04-07T18:04:17Z

recipes/soxr/meta.yaml

+requirements:
+  build:
+    - cmake
+    - {{ compiler('cxx') }}


Suggested change

- {{ compiler('cxx') }}

As suggested by @isuruf

done in e315dc9

traversaro · 2022-04-07T18:04:43Z

@traversaro

See https://github.com/conda-forge/staged-recipes/pull/17935/files#r845431275 .

HosameldinMohamed · 2022-04-08T13:58:46Z

Thanks!

HosameldinMohamed added 2 commits March 22, 2022 19:14

Add soxr recipe

f5d793b

Update license

ffdb96d

HosameldinMohamed force-pushed the addSoxrRecipt branch from 6f10a52 to ffdb96d Compare March 22, 2022 18:37

Add license_file line

fb351ff

add home line

906af17

add linux test

5a70eb9

HosameldinMohamed added 3 commits March 23, 2022 01:11

update build.sh

8d0c85b

add ninja requirement

d206c0b

add host tinyxml

9ff2472

indent host key

dacda37

add libgomp requirement

a2223da

HosameldinMohamed added 2 commits March 23, 2022 01:52

move LICENSE file location

41c6e22

add install prefix

b4e21b1

remove $PREFIX variable

6b4b1d3

HosameldinMohamed added 3 commits March 23, 2022 02:44

temp remove tests

0a17335

remove install prefix

92aece9

add profile variable

e743579

HosameldinMohamed mentioned this pull request Mar 23, 2022

Unable to find soxr.h (from conda-forge dependencies installation on Manjaro) robotology/robotology-superbuild#1008

Closed

use make instead of ninja

197ac4e

traversaro reviewed Mar 24, 2022

View reviewed changes

recipes/soxr/bld.bat Outdated Show resolved Hide resolved

traversaro reviewed Mar 24, 2022

View reviewed changes

recipes/soxr/build.sh Outdated Show resolved Hide resolved

traversaro reviewed Mar 24, 2022

View reviewed changes

recipes/soxr/meta.yaml Show resolved Hide resolved

HosameldinMohamed added 2 commits March 24, 2022 14:00

add traversaro

e11a587

fix typo

c45cae9

carterbox added the c-cpp label Apr 6, 2022

carterbox requested changes Apr 6, 2022

View reviewed changes

recipes/soxr/meta.yaml Outdated Show resolved Hide resolved

HosameldinMohamed and others added 2 commits April 7, 2022 15:32

Update recipes/soxr/meta.yaml

42858a7

`not win` -> `unix` Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>

igr run exp. libstdc++ and rm tinyxml host

4e9b916

fix ignore_run_export place

702a607

ignore libstdcxx instd of libstdc++

628ab3b

traversaro reviewed Apr 7, 2022

View reviewed changes

remove C++ compiler

e315dc9

carterbox merged commit 2fee8f6 into conda-forge:main Apr 7, 2022

HosameldinMohamed deleted the addSoxrRecipt branch April 8, 2022 13:58

traversaro mentioned this pull request May 19, 2022

Requested Conda osx-arm64 recipe Gepetto/gepetto-viewer-corba#164

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add soxr recipe #17935

Add soxr recipe #17935

HosameldinMohamed commented Feb 3, 2022 •

edited

conda-forge-linter commented Feb 3, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 24, 2022

HosameldinMohamed commented Mar 24, 2022

traversaro commented Mar 24, 2022

HosameldinMohamed commented Mar 24, 2022

traversaro commented Mar 24, 2022

carterbox left a comment •

edited

conda-forge-linter commented Apr 7, 2022

conda-forge-linter commented Apr 7, 2022

HosameldinMohamed commented Apr 7, 2022

carterbox commented Apr 7, 2022

isuruf commented Apr 7, 2022

traversaro Apr 7, 2022

HosameldinMohamed Apr 7, 2022

traversaro commented Apr 7, 2022

HosameldinMohamed commented Apr 8, 2022

Add soxr recipe #17935

Add soxr recipe #17935

Conversation

HosameldinMohamed commented Feb 3, 2022 • edited

conda-forge-linter commented Feb 3, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 22, 2022

conda-forge-linter commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

HosameldinMohamed commented Mar 23, 2022

conda-forge-linter commented Mar 23, 2022

HosameldinMohamed commented Mar 24, 2022

HosameldinMohamed commented Mar 24, 2022

traversaro commented Mar 24, 2022

HosameldinMohamed commented Mar 24, 2022

traversaro commented Mar 24, 2022

carterbox left a comment • edited

Choose a reason for hiding this comment

conda-forge-linter commented Apr 7, 2022

conda-forge-linter commented Apr 7, 2022

HosameldinMohamed commented Apr 7, 2022

carterbox commented Apr 7, 2022

isuruf commented Apr 7, 2022

traversaro Apr 7, 2022

Choose a reason for hiding this comment

HosameldinMohamed Apr 7, 2022

Choose a reason for hiding this comment

traversaro commented Apr 7, 2022

HosameldinMohamed commented Apr 8, 2022

HosameldinMohamed commented Feb 3, 2022 •

edited

carterbox left a comment •

edited