-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torchaudio #18331
Torchaudio #18331
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes this is likely going to need a lot of work and help to get working... Any help folks can provide highly appreciated! @conda-forge/torchvision (I borrowed heavily from yall's recipe) |
I really think split recipes introduce unecessary complexity at this stage. I would suggest removing it |
@hmaarrfk Thanks; I'll try that! |
I had started with this in #17082. Problem that I ran into was conda-forge/kaldi-feedstock#15 (though the issue is also that the kaldi-feedstock currently has a blas setup that's quite incompatible with the rest of conda-forge), which I'm attempting to fix in conda-forge/kaldi-feedstock#25. I've gotten the non-windows builds going, but could use some help with windows. |
You are hitting a problem where they expect you to be using git to build You can use git, this is somewhat frowned upon, but I had to ensure maintainability of pytorch. For 1 package, you might be able to pull exactly the right version and keep things in sync. Then you should make some noise upstream to both torchaudio and kaldi to release and use real version numbers. They don't have incentives unless they know their users will use them and it brings benefits to them. |
@hmaarrfk Thanks for the guidance. It looks like they are using a custom build for Kaldi; would I be able to use git to pull that version of Kaldi from the torchaudio repo? Is that something doable? |
Step #1, get things to build. Do what you need at this stage. You might also find this useful: https://github.com/conda-forge/pytorch-cpu-feedstock/blob/main/recipe/meta.yaml |
@hmaarrfk is there a way in meta.yaml to specify the commit hash of a git repo to pull? I can only find how to do this with tags or versions? |
Hmm this is some strange C++ error that I'm not familiar with... @conda-forge/help-c-cpp |
Running into this error even after I added libblas as a build dependencies
|
... did you see/read my comment further up? |
@h-vetinari, yes, can you help me understand how I'd apply what you did in this case? |
It'd be possible to move forward with a unix-only version of conda-forge/kaldi-feedstock#25, but there shouldn't be the assumption that just by virtue of restarting from scratch, you'll automatically overcome the blockers that someone else already identified. Obviously, help on those blockers would be appreciated. |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).