-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add napari-organoid-counter recipe #19238
Add napari-organoid-counter recipe #19238
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be created automatically, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the You can read a bit more about conda-forge at https://conda-forge.org/#contribute @jaimergp, @christinab12, do you agree with being added as maintainers? |
@goanpeca yes thanks! |
|
@goanpeca sorry do you mind explaining where do I have napari 0.4.16 and napari-aicsimageio 0.7.1.? I think I have set it everywhere to napari[all]==0.4.15 and napari-aicsimageio==0.6.1 |
@christinab12 is there any reason to have the tight constraints to napari? Could they be relaxed >= or <=0.5 or similar? |
I have just tested it with setting |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Still working on this! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This one is ready for review @conda-forge/staged-recipes :) |
# - pip check # Fails due to aicsimageio deps and fixed constraintes that were relaxed | ||
requires: | ||
- pip | ||
- pyqt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this listed here and not in run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy napari no longer enforces a qt bidning by default, so when doing
conda install napari -c conda-forge
or pip install napari
you will still need to do
install pyqt
or install pyside
See: https://napari.org/stable/tutorials/fundamentals/installation.html
![Screenshot 2023-10-23 at 5 35 20 PM](https://private-user-images.githubusercontent.com/3627835/277493684-6033b36b-314f-4121-a0b2-17a85fceca08.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMjk4NzEsIm5iZiI6MTcyMTMyOTU3MSwicGF0aCI6Ii8zNjI3ODM1LzI3NzQ5MzY4NC02MDMzYjM2Yi0zMTRmLTQxMjEtYTBiMi0xN2E4NWZjZWNhMDgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MThUMTkwNjExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTlmY2E3NDU4YjNiZjM0MTRiNTRhNGI4NWE0OWExOGEzMjMwZjgwZmQwY2Q4OTQ1NDEwNGMwZjdjOTQyMjBkNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.9jK25OFzwRBiWjSHHAzjyFmO1nsOKh-MWXTK71shAdo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! The best way forward would be to have a metapackage napari-qt (or a more general name without using napari) which builds two variants, one for each qt binding and let all napari recipes depend on this metapackage if they want qt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already discussed and voted against.
See:
- Do not build two variants napari-feedstock#48
- Consider using subpackages instead of build strings for pyside2 vs pyqt napari-feedstock#47
The napari team is ok with having this as is for both conda and pip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really what I think is best, but also not an area where I have something at stake, so let's merge this.
Checklist
[ ] If static libraries are linked in, the license of the static library is packaged.url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).