Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build two variants #48

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Jun 12, 2023

MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.23.1, and conda-forge-pinning 2023.06.11.05.06.40

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Will close #47. This shall NOT be merged yet, until the next napari release is out. When that happens, we will update this PR to reflect the new version. For now, it's only changing how the outputs are built.

MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.23.1, and conda-forge-pinning 2023.06.11.05.06.40
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 🚀

Copy link
Contributor

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool cool. I suppose we need a PR to napari/docs to simul-merge?

@jaimergp jaimergp mentioned this pull request Jul 5, 2023
3 tasks
@jaimergp
Copy link
Member Author

jaimergp commented Jul 5, 2023

Started the integration work at:

@jaimergp jaimergp marked this pull request as ready for review July 12, 2023 09:19
@jaimergp jaimergp changed the title Do not build two variants (preview, DNM) Do not build two variants Jul 12, 2023
psobolewskiPhD added a commit to napari/docs that referenced this pull request Jul 18, 2023
… other changes in our packaging infra (#202)

# Description
Consolidated docs update for info about:

* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77


## Type of change
<!-- Please delete options that are not relevant. -->
- [X] Fixes or improves existing content

# References
* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality

---------

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@jaimergp jaimergp merged commit e6fddb6 into conda-forge:main Jul 18, 2023
2 checks passed
GenevieveBuckley pushed a commit to napari/napari that referenced this pull request Aug 15, 2023
Updates README conda install instructions for the fact that the conda
package no longer pulls Qt—a Qt backend needs to be specified.

# References
conda-forge/napari-feedstock#47
conda-forge/napari-feedstock#48
napari/docs#202

## Type of change
- [x] Documentation
melissawm pushed a commit to melissawm/napari-docs that referenced this pull request Sep 6, 2023
… other changes in our packaging infra (napari#202)

# Description
Consolidated docs update for info about:

* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77


## Type of change
<!-- Please delete options that are not relevant. -->
- [X] Fixes or improves existing content

# References
* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality

---------

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit to napari/napari that referenced this pull request Oct 17, 2023
Updates README conda install instructions for the fact that the conda
package no longer pulls Qt—a Qt backend needs to be specified.

# References
conda-forge/napari-feedstock#47
conda-forge/napari-feedstock#48
napari/docs#202

## Type of change
- [x] Documentation
Czaki pushed a commit to napari/napari that referenced this pull request Oct 31, 2023
… other changes in our packaging infra (#202)

# Description
Consolidated docs update for info about:

* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77

## Type of change
<!-- Please delete options that are not relevant. -->
- [X] Fixes or improves existing content

# References
* conda-forge/napari-feedstock#48
* napari/packaging#75
* napari/packaging#77

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality

---------

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using subpackages instead of build strings for pyside2 vs pyqt
3 participants