New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for google-weather-tools #20892
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
The recipe still looks very wrong. I strongly suggest you try out |
…ed-recipe into anthro
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-cloud-storage:
For recipes/google-cloud-storage:
Documentation on acceptable licenses can be found here. For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-cloud-storage:
For recipes/google-cloud-storage:
Documentation on acceptable licenses can be found here. For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
@conda-forge/help-python The recipe has passed all checks and is ready for your review. Thanks. |
git_rev: "{{ git_rev }}" | ||
|
||
build: | ||
skip: true # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip: true # [win] | |
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy Thanks for your help and happy new year! Some of our runtime dependencies are not supported in Windows, what is the right way to release for Unix only if having noarch is mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this answer, I assume the recipe should not be noarch
since it's not supported in Windows. Please correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, if it's just that the dependencies are unavailable on Windows, that's fine for this to be noarch. It's only a problem with dependencies that are only install on Windows/not-Windows. noarch packages are generally only built on Linux systems, which will succeed. The missing dependencies will then keep it from being installable on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by the discussion here. In my understanding, the solution to move forward is to configure this to be noarch.
To add some general background context: We have not yet implemented windows support in the package we want to release (google/weather-tools#64). If we set this to noarch, does that mean we have to fix this bug in order to proceed?
Thanks for your inputs, @dopplershift and @xhochy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well since you said:
Some of our runtime dependencies are not supported in Windows
That's why I said noarch was the right answer. This is the first time it's been mentioned that it doesn't work properly on Windows. In that case, we can proceed with non-noarch.
Having said that though, it looks like the problem is just that you're using scripts
for the executables. That's pretty easy to move to console_scripts
which work on Windows and are supported by our noarch builds.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/google-weather-tools:
For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/google-weather-tools:
Documentation on acceptable licenses can be found here. |
@conda-forge/help-python The recipe has passed all checks and is ready for your review. Thanks. |
git_url: https://github.com/google/weather-tools.git | ||
git_rev: "{{ git_rev }}" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally only want to be using released versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - is there a way to configure this to reflect our git release tags?
git_url: https://github.com/google/weather-tools.git | ||
git_rev: "{{ git_rev }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all you want is to just get a git tag, use:
git_url: https://github.com/google/weather-tools.git | |
git_rev: "{{ git_rev }}" | |
url: https://github.com/google/weather-tools/archive/refs/tags/v{{ version }}.tar.gz | |
sha256: YOURSHAHERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will TAL at this soon.
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).