-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for google-weather-tools #20892
base: main
Are you sure you want to change the base?
Changes from all commits
14a3a1a
a92b905
348c504
ed2c25d
88926bf
1939788
c947a12
cc90c7a
66e7210
cc919c6
7784171
c67a7a3
6e73413
53d69f5
3ad72e2
2b78240
aa7111a
2001eba
7bec93a
2385d11
f7c5732
5d9b764
e51ec7e
2331c53
6988bb3
7833075
a67656e
e50573b
1de804e
b2c121c
7fb68b3
5e15928
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,85 @@ | ||||||
{% set name = "google-weather-tools" %} | ||||||
{% set version = "0.3.2" %} | ||||||
{% set git_rev = "conda-candidate-v0" %} | ||||||
|
||||||
package: | ||||||
name: "{{ name|lower }}" | ||||||
version: "{{ version }}" | ||||||
|
||||||
source: | ||||||
git_url: https://github.com/google/weather-tools.git | ||||||
git_rev: "{{ git_rev }}" | ||||||
|
||||||
Comment on lines
+10
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We generally only want to be using released versions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 - is there a way to configure this to reflect our git release tags? |
||||||
build: | ||||||
skip: true # [win] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xhochy Thanks for your help and happy new year! Some of our runtime dependencies are not supported in Windows, what is the right way to release for Unix only if having noarch is mandatory? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to this answer, I assume the recipe should not be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, if it's just that the dependencies are unavailable on Windows, that's fine for this to be noarch. It's only a problem with dependencies that are only install on Windows/not-Windows. noarch packages are generally only built on Linux systems, which will succeed. The missing dependencies will then keep it from being installable on Windows. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a bit confused by the discussion here. In my understanding, the solution to move forward is to configure this to be noarch. To add some general background context: We have not yet implemented windows support in the package we want to release (google/weather-tools#64). If we set this to noarch, does that mean we have to fix this bug in order to proceed? Thanks for your inputs, @dopplershift and @xhochy. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well since you said:
That's why I said noarch was the right answer. This is the first time it's been mentioned that it doesn't work properly on Windows. In that case, we can proceed with non-noarch. Having said that though, it looks like the problem is just that you're using |
||||||
number: 0 | ||||||
script: > | ||||||
{{ PYTHON }} -m pip install . -vv && | ||||||
{{ PYTHON }} -m pip install ./weather_dl -vv && | ||||||
{{ PYTHON }} -m pip install ./weather_mv -vv && | ||||||
{{ PYTHON }} -m pip install ./weather_sp -vv | ||||||
|
||||||
requirements: | ||||||
host: | ||||||
- pip | ||||||
- python =3.8 | ||||||
- gdal =3.5.1 | ||||||
- setuptools_scm | ||||||
run: | ||||||
- apache-beam[gcp] ==2.40.0 # [unix] | ||||||
- earthengine-api >=0.1.263 | ||||||
- gdal =3.5.1 | ||||||
- metview-batch | ||||||
- python =3.8 | ||||||
- absl-py | ||||||
blackvvine marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
- cdsapi | ||||||
- cfgrib | ||||||
- dataclasses | ||||||
- ecmwf-api-client | ||||||
- geojson | ||||||
- google-apitools | ||||||
- google-cloud-bigquery | ||||||
- google-cloud-datastore | ||||||
- google-cloud-firestore | ||||||
- google-cloud-storage | ||||||
- metview-batch # [unix] | ||||||
- netcdf4 | ||||||
- numpy | ||||||
- pandas | ||||||
- pygrib | ||||||
- pyproj | ||||||
- pytype | ||||||
- rasterio | ||||||
- requests | ||||||
- rioxarray | ||||||
- simplejson # [unix] | ||||||
- urllib3 | ||||||
- xarray | ||||||
- xarray-beam # [unix] | ||||||
|
||||||
test: | ||||||
imports: | ||||||
- weather_dl # [unix] | ||||||
- weather_mv # [unix] | ||||||
- weather_mv.loader_pipeline # [unix] | ||||||
- weather_sp # [unix] | ||||||
- weather_sp.splitter_pipeline # [unix] | ||||||
requires: | ||||||
- pytest | ||||||
- pytest-subtests | ||||||
- flake8 | ||||||
|
||||||
about: | ||||||
home: "https://weather-tools.readthedocs.io/" | ||||||
license: Apache Software | ||||||
license_family: APACHE | ||||||
license_file: LICENSE | ||||||
summary: "Apache Beam pipelines to make weather data accessible and useful." | ||||||
doc_url: https://github.com/google/weather-tools/tree/main/docs | ||||||
dev_url: https://github.com/google/weather-tools/blob/main/LICENSE | ||||||
|
||||||
extra: | ||||||
recipe-maintainers: | ||||||
- blackvvine | ||||||
- alxmrs | ||||||
- mahrsee1997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all you want is to just get a git tag, use:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will TAL at this soon.