Add poliastro and jplephem recipes #214
Conversation
|
Oh well... my second last name has a non-ASCII character. https://github.com/conda/conda/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+unicode+OR+ascii (Closest: conda/conda#1486) Would you consider using Miniconda3 on https://github.com/pelson/Obvious-CI? |
|
Could you please open the above as an issue on this repo (with reference back to this PR and conda issue)? |
|
The problem is here: https://github.com/conda-forge/staged-recipes/blob/280b670/.CI/build_all#L8 I guess it would be a matter of changing the major Python version. |
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
|
|
|||
| pip install --no-deps . | |||
There was a problem hiding this comment.
Ack! Can we not use pip? This is likely to cause problems for conda.
There was a problem hiding this comment.
I've seems some recipes like that in the wild and I wonder what are the possible problems.
There was a problem hiding this comment.
In fact this works just fine, I've been using this recipe for a while already:
I don't know what is the current (March 2016) consensus on this, but half a year ago this thread on numpy-dev prompted me to change that line:
https://mail.scipy.org/pipermail/numpy-discussion/2015-October/074086.html
Of course I can restore it to its previous state.
There was a problem hiding this comment.
Yes, let's use setup.py. Sometimes conda can be a bit finicky with using pip in a recipe. Normally we tack on a few arguments that tend to help anyways. In particular, we do the following.
python setup.py install --single-version-externally-managed --record record.txt
There was a problem hiding this comment.
Got it, I will make the change then. For reference: https://github.com/conda-forge/cartopy-feedstock/blob/a23c28a/recipe/build.sh#L5
There was a problem hiding this comment.
Well, when it comes to Mac and Linux. We will fold this into script under build in the meta.yaml file. Unfortunately, we can't do this for Windows due to a conda build bug.
|
Added some comments for the recipe. Once these are done we can go through another round. |
|
Hi! This is the friendly conda-forge-admin automated user. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jplephem:
|
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Yeah, that linter is pretty neat, right? Very new addition (thanks to @pelson). |
| @@ -0,0 +1,2 @@ | |||
| %PYTHON% setup.py install | |||
There was a problem hiding this comment.
Also needs --single-version-externally-managed --record record.txt.
|
Is everything OK with the OS X build? https://travis-ci.org/conda-forge/staged-recipes/jobs/118999303#L296 Perhaps setuptools is missing? |
|
|
||
| requirements: | ||
| build: | ||
| - python |
Yep. If poliastro uses setuptools add it as a dependency. Otherwise just do a |
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I forgot to add that poliastro does not support Python 2. What would be the best way to disable it from the build? |
Add this to your build section (last line): build:
number: 0
skip: True # [py2k] |
|
Well, I just remembered another PyPI-only requirement I've got with poliastro. I will have to step back and provide a feedstock for it too... 😤 |
|
Done, waiting on #226. |
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Closing and reopening to trigger CI. |
|
@Juanlu001 sometimes that does not work. You can ping me to re-start them manually. |
|
@ocefpaf True, it did work in this case though. Don't worry, I think I still have to make some extra commits 😅 |
|
No it didn't 😉 (I restarted CircleCI.) |
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
The Windows builds are failing because pytest-benchmark is not available on Windows yet. This is because the build is still queued on AppVeyor 😦 https://ci.appveyor.com/project/conda-forge/pytest-benchmark-feedstock |
|
There is nothing you can do now but wait... |
|
Some of the matrix items passed, and I have no reason to believe that the others wont now that the dependencies are available. I'm going to merge this, but if you could keep an eye on the feedstock(s) and raise any issues there if there are Windows build problems. |
|
Yeah, I have taken the same attitude with AppVeyor before. We should really discuss our options here because it is become clear the current strategy is not working. |
|
Thanks guys! 🎉 I will make use of this material for my talk at PyData Madrid next week 😄 |
|
Folks, is there a way to restart the poliastro builds? I just checked the poliastro-feedstock recipes and the jplephem package was missing. I suppose that if they were created at the same time, perhaps the dependencies were not in place by the time the CI builds triggered. |
|
@Juanlu001 I re-started the CIs for you, but you should be able to re-start CircleCI and Travis-CI as you are part of the team poliastro. I guess you'll still need to ask for help to re-start AppVeyor. PS: Note that Travis-CI might not be in sync and may not show the re-start button. Just sync it manually and the button will appear. |
|
Perfect, thanks! |
|
An alternative heavy weight solution: add a commit to the repo 😉 (though I know it isn't ideal). Not looking forward to it, but I suspect I'm going to have to get down and dirty with the AppVeyor API sometime soon. 😒 |
astrojuanlu
changed the title
jakirkham
changed the title
By suggestion of @pelson I'm trying conda-forge with my own package. It was not clear to me what the rules are for a proper feedstock so I will wait for the bot to lint my recipe :) (inspired by #84 (comment))