Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flite text-to-speech recipe #21976

Merged
merged 8 commits into from
Dec 27, 2023
Merged

Add flite text-to-speech recipe #21976

merged 8 commits into from
Dec 27, 2023

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Feb 7, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flite) and found some lint.

Here's what I've got...

For recipes/flite:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flite) and found it was in an excellent condition.

@peci1
Copy link
Contributor Author

peci1 commented Feb 7, 2023

@conda-forge/staged-recipes, ready for review!

@peci1 peci1 changed the title Add flite TTS recipe Add flite text-to-speech recipe Feb 8, 2023
@stale
Copy link

stale bot commented Jul 11, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added stale will be closed in 30 days and removed stale will be closed in 30 days labels Jul 11, 2023
@peci1
Copy link
Contributor Author

peci1 commented Jul 11, 2023

@conda-forge/staged-recipes, ready for review!

@ocefpaf
Copy link
Member

ocefpaf commented Jul 11, 2023

Let's close and open this one to toggle the CIs. The logs are long gone here.

@ocefpaf ocefpaf closed this Jul 11, 2023
@ocefpaf ocefpaf reopened this Jul 11, 2023
recipes/flite/build.sh Show resolved Hide resolved

mkdir -p "${PREFIX}/lib"

cp -P build/lib/lib*.so.* "${PREFIX}/lib/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use SHLIB_EXT instead of .so to catch the macOS .dylib too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the latest build. It doesn't seem to build shared libs on Mac. There is even an open PR for that: festvox/flite#94 . But again, I'm not very much into maintaining unmerged PRs. So I'd suggest reverting the latest commit and distributing the shared libs only on linux.

recipes/flite/install_devel.sh Show resolved Hide resolved
recipes/flite/meta.yaml Show resolved Hide resolved
recipes/flite/meta.yaml Show resolved Hide resolved
@ocefpaf
Copy link
Member

ocefpaf commented Jul 12, 2023

macOS is failing with:

cp -P 'build/lib/lib*.dylib.*' /Users/runner/mambaforge/conda-bld/flite-tts_1689110067507/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/
cp: build/lib/lib*.dylib.*: No such file or directory

You can try a local build to see the right name of this file but I'm guessing that maybe a change from build/lib/lib*.dylib.* to build/lib/*.dylib* may be enough.


mkdir -p "${PREFIX}/lib"

cp -P build/lib/lib*${SHLIB_EXT}.* "${PREFIX}/lib/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this fixes the macOS build.

Suggested change
cp -P build/lib/lib*${SHLIB_EXT}.* "${PREFIX}/lib/"
cp -P build/lib/*${SHLIB_EXT}* "${PREFIX}/lib/"

@peci1
Copy link
Contributor Author

peci1 commented Jul 12, 2023

This is the list of all files on OS X build:

+ ls build/lib/
libflite.a
libflite_cmu_grapheme_lang.a
libflite_cmu_grapheme_lex.a
libflite_cmu_indic_lang.a
libflite_cmu_indic_lex.a
libflite_cmu_time_awb.a
libflite_cmu_us_awb.a
libflite_cmu_us_kal.a
libflite_cmu_us_kal16.a
libflite_cmu_us_rms.a
libflite_cmu_us_slt.a
libflite_cmulex.a
libflite_usenglish.a

The package just doesn't build shared libs on OS X. That's what the referenced PR would solve. I can certainly turn it into an issue in the feedstock once it is created.

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev packages are skipped for osx because upstream does not support building non-static libs for osx yet. However, the flite binary is still built for osx.

@carterbox
Copy link
Member

This package is strange because libflite.so.1 links to libflite.so.2.3. As opposed to libflite.so.2 linking to libflite.so.2.3.

@carterbox carterbox merged commit 8c97e2c into conda-forge:main Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants