Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ipynbname recipe #23585

Closed
wants to merge 5 commits into from
Closed

Adding ipynbname recipe #23585

wants to merge 5 commits into from

Conversation

msm1089
Copy link

@msm1089 msm1089 commented Aug 5, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file (<your_package.yaml>) into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/<your_package>.yaml.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Feedstock with the same name exists in conda-forge.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes:

  • A conda package with same name (ipynbname) already exists.

@msm1089 msm1089 changed the title Add recipe Adding ipynbname recipe Aug 5, 2023
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@msm1089
Copy link
Author

msm1089 commented Aug 5, 2023

Package author here, willing to maintain recipe

@msm1089
Copy link
Author

msm1089 commented Aug 5, 2023

@conda-forge-admin, please ping team

Hi, I got an invite to join conda-forge following a recent release of a package on PyPi. The email I got did not really explain what I should do. After reading the README for staged-recipes I have tried following the instructions to add a recipe but all the CI is failing. I think I must be doing something wrong, but also I think the recipe may have already been added, so that I do not actually need to add it myself...could you help me out with what I am supposed to be doing after accepting the invite, if anything?

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Feedstock with the same name exists in conda-forge.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes:

  • A conda package with same name (ipynbname) already exists.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 7, 2023

The name of the recipe file must be meta.yaml.

@ocefpaf ocefpaf mentioned this pull request Aug 7, 2023
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ipynbname) and found some lint.

Here's what I've got...

For recipes/ipynbname:

  • Feedstock with the same name exists in conda-forge.

For recipes/ipynbname:

  • A conda package with same name (ipynbname) already exists.

@msm1089
Copy link
Author

msm1089 commented Aug 8, 2023

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ipynbname) and found some lint.

Here's what I've got...

For recipes/ipynbname:

  • Feedstock with the same name exists in conda-forge.

For recipes/ipynbname:

  • A conda package with same name (ipynbname) already exists.

@conda-forge-admin, please ping team

So I fixed the recipe name. The lints suggest to me that the recipe already exists. As I said in previous message, I am not sure what (if any) action I should be taking after accepting the invite I got by email. Assumed I needed to add the recipe, but cannot. Could someone let me know what is going on? :)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 8, 2023

So I fixed the recipe name. The lints suggest to me that the recipe already exists. As I said in previous message, I am not sure what (if any) action I should be taking after accepting the invite I got by email. Assumed I needed to add the recipe, but cannot. Could someone let me know what is going on? :)

I missed that part. You don't need to re-submit the recipe, closing this one.

You should have access to https://github.com/conda-forge/ipynbname-feedstock/ already. If not, you can update the team there with the bot command: https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-update-team

@ocefpaf ocefpaf closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants