Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binda #24104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added binda #24104

wants to merge 4 commits into from

Conversation

jamiecash
Copy link

@jamiecash jamiecash commented Sep 29, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/meta.yaml.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes:

  • The pypa build package has been renamed to python-build.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/binda) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/binda:

  • The pypa build package has been renamed to python-build.

@jamiecash
Copy link
Author

@conda-forge/help-python PR ready for review

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (binda, recipes/binda) and found some lint.

Here's what I've got...

For binda:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For binda:

  • The pypa build package has been renamed to python-build.

For recipes/binda:

  • The pypa build package has been renamed to python-build.

@jamiecash
Copy link
Author

@conda-forge/help-python Hi, the above build keeps failing. I can build on my local machine and have published to PyPi. The build message is not clear what is going wrong. Could you help.

@@ -0,0 +1,50 @@
{% set name = "binda" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file/directory is outside of the recipes directory. It looks like a newer copy of recipes/binda/meta.yaml so it should be moved into that location (within recipes). I'm going to assume that this is the latest and am ignoring the other meta.yaml.


extra:
recipe-maintainers:
- jking-ca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This github user is different from the account submitting this recipe and does not appear to be the same person.

script: {{ PYTHON }} -m pip install . -vv

requirements:
host:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items under [build-system] requires should go in the host requirements section.

host:
- pip
- python >=3.6
run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a general comment, I realize that many of these dependencies are listed as dependencies in the pyproject.toml and thus need to be listed here to satisfy the pip check, but really all but python, numpy and pandas are just for development and shouldn't really be run time requirements. I might put in a PR to fix this upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants