-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added binda #24104
base: main
Are you sure you want to change the base?
Added binda #24104
Conversation
Hi! Thanks for your contribution to conda-forge. For example: if your recipe is currently under |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes:
For recipes:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/binda:
|
@conda-forge/help-python PR ready for review |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For binda:
For binda:
For recipes/binda:
|
@conda-forge/help-python Hi, the above build keeps failing. I can build on my local machine and have published to PyPi. The build message is not clear what is going wrong. Could you help. |
@@ -0,0 +1,50 @@ | |||
{% set name = "binda" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file/directory is outside of the recipes
directory. It looks like a newer copy of recipes/binda/meta.yaml
so it should be moved into that location (within recipes
). I'm going to assume that this is the latest and am ignoring the other meta.yaml.
|
||
extra: | ||
recipe-maintainers: | ||
- jking-ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This github user is different from the account submitting this recipe and does not appear to be the same person.
script: {{ PYTHON }} -m pip install . -vv | ||
|
||
requirements: | ||
host: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items under [build-system]
requires should go in the host
requirements section.
host: | ||
- pip | ||
- python >=3.6 | ||
run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a general comment, I realize that many of these dependencies are listed as dependencies in the pyproject.toml
and thus need to be listed here to satisfy the pip check
, but really all but python, numpy and pandas are just for development and shouldn't really be run time requirements. I might put in a PR to fix this upstream.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).