Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binda #24104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions binda/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{% set name = "binda" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file/directory is outside of the recipes directory. It looks like a newer copy of recipes/binda/meta.yaml so it should be moved into that location (within recipes). I'm going to assume that this is the latest and am ignoring the other meta.yaml.

{% set version = "1.0.22" %}


package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/binda-{{ version }}.tar.gz
sha256: 4c902a5cf5034eaf9e88e1ad04e9108121da72dc1c2ea71cd3520a1f3fff7691

build:
number: 0
noarch: python
script: {{ PYTHON }} -m pip install . -vv

requirements:
host:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items under [build-system] requires should go in the host requirements section.

- pip
- python >=3.6
run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a general comment, I realize that many of these dependencies are listed as dependencies in the pyproject.toml and thus need to be listed here to satisfy the pip check, but really all but python, numpy and pandas are just for development and shouldn't really be run time requirements. I might put in a PR to fix this upstream.

- build
- flake8
- hatch-vcs
- hatchling
- numpy
- pandas
- pdoc
- pytest
- python >=3.6
- twine

test:
imports:
- binda
commands:
- pip check
requires:
- pip

about:
home: https://pypi.org/project/binda/
summary: Read and write binary data using Pandas
license: MIT
license_file: LICENSE

extra:
recipe-maintainers:
- jking-ca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This github user is different from the account submitting this recipe and does not appear to be the same person.

51 changes: 51 additions & 0 deletions recipes/binda/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{% set name = "binda" %}
{% set version = "1.0.20" %}


package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/binda-{{ version }}.tar.gz
sha256: 52348770be0dc1aa1944da4d5d259c8aacdd7b279fe7be8f4a61840e2ecfec22

build:
number: 0
noarch: python
script: {{ PYTHON }} -m pip install . -vv

requirements:
host:
- pip
- python >=3.6
run:
- build
- flake8
- grayskull
- hatch-vcs
- hatchling
- numpy
- pandas
- pdoc
- pytest
- python >=3.6
- twine

test:
imports:
- binda
commands:
- pip check
requires:
- pip

about:
home: https://pypi.org/project/binda/
summary: Read and write binary data using Pandas
license: MIT
license_file: LICENSE

extra:
recipe-maintainers:
- jking-ca
Loading