Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add miniopy-async #25848

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat: add miniopy-async #25848

merged 2 commits into from
Mar 27, 2024

Conversation

hlf20010508
Copy link
Contributor

@hlf20010508 hlf20010508 commented Mar 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/miniopy-async) and found some lint.

Here's what I've got...

For recipes/miniopy-async:

  • The following maintainers have not yet confirmed that they are willing to be listed here: L-ing. Please ask them to comment on this PR if they are.

@hlf20010508
Copy link
Contributor Author

@conda-forge/help-python, ready for review

recipes/miniopy-async/meta.yaml Outdated Show resolved Hide resolved
From L-ing to hlf20010508.

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/miniopy-async) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member

@hlf20010508 it is okay for noarch package to fails on Windows with a missing dependency (c.f. #25702 (comment)) so this should be fine assuming the review team doesn't have any additional changes. 👍

@hlf20010508
Copy link
Contributor Author

@matthewfeickert so I need to comment this again?

@conda-forge/help-python, ready for review

@matthewfeickert
Copy link
Member

matthewfeickert commented Mar 25, 2024

so I need to comment this again?

@hlf20010508 Nope! You're good. That just applies the language and review-requested labels. As you can see from review-requested there's a lot of them, and the review team is a small group of volunteers, so it is not uncommon for it to take around a day or so for them to check all the recent requested reviews (especially during the weekend). If you haven't heard back from them within maybe 2 days then we can ping them to ask for a review.

Everything looks good to me though, so I think your review should be quick!

@hlf20010508
Copy link
Contributor Author

@matthewfeickert Alright. Thank you for your asistance.

@matthewfeickert
Copy link
Member

(It probably helps though to check all the completed items on the checklist (#25848 (comment)) and mark those not relevant as N/A)

@matthewfeickert
Copy link
Member

matthewfeickert commented Mar 27, 2024

@conda-forge/help-python 👋 if you have time to review, this PR is ready to go. The failing build on Windows is expected given a lack of dependency support there, but this is left as noarch for the reason given in #25702 (comment).

@ocefpaf ocefpaf merged commit b448f17 into conda-forge:main Mar 27, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants