-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add miniopy-async #25848
feat: add miniopy-async #25848
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/miniopy-async:
|
@conda-forge/help-python, ready for review |
From L-ing to hlf20010508. Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@hlf20010508 it is okay for noarch package to fails on Windows with a missing dependency (c.f. #25702 (comment)) so this should be fine assuming the review team doesn't have any additional changes. 👍 |
@matthewfeickert so I need to comment this again?
|
@hlf20010508 Nope! You're good. That just applies the language and Everything looks good to me though, so I think your review should be quick! |
@matthewfeickert Alright. Thank you for your asistance. |
(It probably helps though to check all the completed items on the checklist (#25848 (comment)) and mark those not relevant as |
@conda-forge/help-python 👋 if you have time to review, this PR is ready to go. The failing build on Windows is expected given a lack of dependency support there, but this is left as |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).