-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add madminer recipe #25702
feat: Add madminer recipe #25702
Conversation
I am willing to be a maintainer. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
32a40ed
to
0eb0174
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/madminer:
|
0eb0174
to
d538565
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/madminer:
|
3ad6106
to
7ffd582
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/madminer/meta.yaml
Outdated
# * uproot3-methods does not support Python 3.12+ | ||
# * Non noarch packages should have python requirement without any version constraints | ||
# so use or statements in skip | ||
skip: true # [win or py<38 or py>=312] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't use noarch
as there are no distributions of pytorch
for Windows, which means that can't place version restrictions on python
in the requirements, so need to use the skip
to restrict Python to 3.8+ but not allow Python 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK for noarch package to fails on Windows with a missing dependency. We prefer noarch b/c it is faster to build and the package will be ready when the missing dependency is available on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay I'll revert this and then tag you when I have this ready. 👍
@conda-forge/help-python, ready for review! |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/madminer:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
* c.f. https://github.com/madminer-tool/madminer * Recipe generated with grayskull via 'grayskull pypi madminer' and then edited to add additional information. * Use 'noarch:python' though Windows will fail, as requested by conda-forge admin.
6ff31c1
to
7c3a3e1
Compare
Co-authored-by: Filipe <ocefpaf@gmail.com>
Thanks for the review and help @ocefpaf! |
Note to self: This PR generated https://github.com/conda-forge/madminer-feedstock |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).