Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add madminer recipe #25702

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@matthewfeickert
Copy link
Member Author

I am willing to be a maintainer.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found some lint.

Here's what I've got...

For recipes/madminer:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found some lint.

Here's what I've got...

For recipes/madminer:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found it was in an excellent condition.

# * uproot3-methods does not support Python 3.12+
# * Non noarch packages should have python requirement without any version constraints
# so use or statements in skip
skip: true # [win or py<38 or py>=312]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use noarch as there are no distributions of pytorch for Windows, which means that can't place version restrictions on python in the requirements, so need to use the skip to restrict Python to 3.8+ but not allow Python 3.12.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK for noarch package to fails on Windows with a missing dependency. We prefer noarch b/c it is faster to build and the package will be ready when the missing dependency is available on Windows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay I'll revert this and then tag you when I have this ready. 👍

@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found some lint.

Here's what I've got...

For recipes/madminer:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/madminer) and found it was in an excellent condition.

* c.f. https://github.com/madminer-tool/madminer
* Recipe generated with grayskull via 'grayskull pypi madminer'
  and then edited to add additional information.
* Use 'noarch:python' though Windows will fail, as requested by
  conda-forge admin.
recipes/madminer/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Filipe <ocefpaf@gmail.com>
@ocefpaf ocefpaf merged commit 002b2a0 into conda-forge:main Mar 12, 2024
3 of 5 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-madminer branch March 12, 2024 21:43
@matthewfeickert
Copy link
Member Author

Thanks for the review and help @ocefpaf!

@matthewfeickert
Copy link
Member Author

Note to self: This PR generated https://github.com/conda-forge/madminer-feedstock

@matthewfeickert matthewfeickert mentioned this pull request Mar 25, 2024
10 tasks
@matthewfeickert matthewfeickert mentioned this pull request May 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants