Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hepdata-lib #26293

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 9, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Resolves HEPData/hepdata_lib#117

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hepdata-lib) and found some lint.

Here's what I've got...

For recipes/hepdata-lib:

  • The following maintainers have not yet confirmed that they are willing to be listed here: clelange. Please ask them to comment on this PR if they are.

@matthewfeickert
Copy link
Member Author

@clelange Can you comment below if you are willing to be a maintainer on this conda-forge recipe (required before a conda-forge maintainer can review this). (c.f. #26293 (comment)) As the package author I want to include you, though I am willing to help do the maintenance of hitting "merge" for future releases.

Comment on lines +12 to +15
build:
# Will fail on Windows as imagemagick does not support Windows builds, but
# failing on a noarch is preferred by the conda-forge maintainers
noarch: python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows build will fail, but that is expected, and so leaving this as is given #25702 (comment).

@clelange
Copy link

Happy to be a maintainer.

* c.f. https://github.com/HEPData/hepdata_lib
* Recipe generated with grayskull via 'grayskull pypi hepdata-lib'
  and then edited to add additional information.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hepdata-lib) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review

@xhochy xhochy merged commit bcb86ba into conda-forge:main May 10, 2024
3 of 5 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-hepdata-lib branch May 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Build conda channel for hepdata_lib
3 participants