Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add siphash24 #26856

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Add siphash24 #26856

merged 2 commits into from
Jul 8, 2024

Conversation

inducer
Copy link
Contributor

@inducer inducer commented Jul 4, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

github-actions bot commented Jul 4, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (siphash24) and found some lint.

Here's what I've got...

For siphash24:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/siphash24) and found some lint.

Here's what I've got...

For recipes/siphash24:

  • The following maintainers have not yet confirmed that they are willing to be listed here: matthiasdiener. Please ask them to comment on this PR if they are.

@inducer
Copy link
Contributor Author

inducer commented Jul 4, 2024

@matthiasdiener Could you confirm you'd like to co-maintain this?

@matthiasdiener
Copy link
Contributor

@matthiasdiener Could you confirm you'd like to co-maintain this?

Sure, that sounds good!

@matthiasdiener
Copy link
Contributor

here is a suggestion for the recipe:

diff --git a/recipes/siphash24/meta.yaml b/recipes/siphash24/meta.yaml
index 053612224a..d69fa93183 100644
--- a/recipes/siphash24/meta.yaml
+++ b/recipes/siphash24/meta.yaml
@@ -10,19 +10,27 @@ source:
   sha256: 242d6901a81260f618938635a25ae7f208e744f7ee6c571f1b255c1c4c62917d

 build:
-  noarch: python
   script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
   number: 0
+  skip: true  # [win]

 requirements:
+  build:
+    - python                                 # [build_platform != target_platform]
+    - cross-python_{{ target_platform }}     # [build_platform != target_platform]
+    - {{ compiler('c') }}
+    - {{ stdlib('c')}}
+    - meson >=1.0.0                          # [build_platform != target_platform]
+    - cython >=3.0.2                         # [build_platform != target_platform]
+    - meson-python >=0.14.0                  # [build_platform != target_platform]
   host:
-    - python >=3.7
+    - python
     - cython >=3.0.2
     - meson >=1.0.0
     - meson-python >=0.14.0
     - pip
   run:
-    - python >=3.7
+    - python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/siphash24) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/siphash24:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [22].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/siphash24) and found it was in an excellent condition.

@inducer
Copy link
Contributor Author

inducer commented Jul 5, 2024

@conda-forge-admin please restart ci

@matthiasdiener
Copy link
Contributor

matthiasdiener commented Jul 5, 2024

Until conda-forge/status#181 is resolved, CI will not be able to run I think.

@inducer inducer marked this pull request as ready for review July 8, 2024 16:58
@inducer
Copy link
Contributor Author

inducer commented Jul 8, 2024

@conda-forge/help-python I think this is ready for a look.

recipes/siphash24/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@isuruf isuruf merged commit ef1a070 into conda-forge:main Jul 8, 2024
5 checks passed
@inducer inducer deleted the siphash24 branch July 8, 2024 19:32
@dnicolodi
Copy link

Hello. sipahash24 maintainer here. If I can be added as maintainer of the conda-forge recipe I can try to keep it updated for future releases of siphash24. I don't have experience in maintaining conda-force recipes, but from what I see in this PR it does not seem to be rocket science :)

@inducer
Copy link
Contributor Author

inducer commented Jul 8, 2024

Thanks again! conda-forge/siphash24-feedstock#4 should add you.

Also sorry again about the multiple different attempts at doing this.

@dnicolodi
Copy link

Thanks and no worries. conda-forge uses a level of automation I'm not used to 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants