-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add siphash24 #26856
Add siphash24 #26856
Conversation
Hi! Thanks for your contribution to conda-forge. If these changes are intentional (and you aren't submitting a recipe), please attach a |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For siphash24:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/siphash24:
|
@matthiasdiener Could you confirm you'd like to co-maintain this? |
Sure, that sounds good! |
here is a suggestion for the recipe: diff --git a/recipes/siphash24/meta.yaml b/recipes/siphash24/meta.yaml
index 053612224a..d69fa93183 100644
--- a/recipes/siphash24/meta.yaml
+++ b/recipes/siphash24/meta.yaml
@@ -10,19 +10,27 @@ source:
sha256: 242d6901a81260f618938635a25ae7f208e744f7ee6c571f1b255c1c4c62917d
build:
- noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
+ skip: true # [win]
requirements:
+ build:
+ - python # [build_platform != target_platform]
+ - cross-python_{{ target_platform }} # [build_platform != target_platform]
+ - {{ compiler('c') }}
+ - {{ stdlib('c')}}
+ - meson >=1.0.0 # [build_platform != target_platform]
+ - cython >=3.0.2 # [build_platform != target_platform]
+ - meson-python >=0.14.0 # [build_platform != target_platform]
host:
- - python >=3.7
+ - python
- cython >=3.0.2
- meson >=1.0.0
- meson-python >=0.14.0
- pip
run:
- - python >=3.7
+ - python |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/siphash24:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please restart ci |
Until conda-forge/status#181 is resolved, CI will not be able to run I think. |
@conda-forge/help-python I think this is ready for a look. |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Hello. |
Thanks again! conda-forge/siphash24-feedstock#4 should add you. Also sorry again about the multiple different attempts at doing this. |
Thanks and no worries. conda-forge uses a level of automation I'm not used to 🙂 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).