Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use siphash for persistent hashing #242

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Use siphash for persistent hashing #242

merged 1 commit into from
Jul 5, 2024

Conversation

inducer
Copy link
Owner

@inducer inducer commented Jul 3, 2024

I don't know how much of a bottleneck the hash computation is in mirgecom compiles, but at the same time, I can't think of a good reason to not do this. Our use case very much falls into the "many small messages" category, so this graph is pretty compelling:

grafik

(from https://cr.yp.to/siphash/siphash-20120918.pdf)

A few things need to happen in order to make this go:

cc @matthiasdiener

@inducer
Copy link
Owner Author

inducer commented Jul 3, 2024

In addition, this will likely save considerable amounts of DRAM and disk. (Consider the "failing" test for the SQLite file that's now "too small".)

@inducer
Copy link
Owner Author

inducer commented Jul 3, 2024

Python also uses siphash internally (for hash), but AFAIK that implementation is not individually accessible.

@inducer inducer marked this pull request as ready for review July 5, 2024 17:32
@inducer inducer merged commit a2c5c53 into main Jul 5, 2024
16 checks passed
@inducer inducer deleted the siphash branch July 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant