Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airflow 1.8.0 recipe to conda-forge. #2882

Merged
merged 9 commits into from
May 12, 2017
Merged

Conversation

sodre
Copy link
Member

@sodre sodre commented Apr 28, 2017

The recipe currently does not build pass the test because

I will be working to create additional packages for those.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airflow) and found it was in an excellent condition.

sodre added a commit to sodre/staged-recipes that referenced this pull request Apr 28, 2017
This is a requirement for the airflow PR conda-forge#2882
sodre added a commit to sodre/staged-recipes that referenced this pull request Apr 28, 2017
This is a requirement for the airflow PR conda-forge#2882
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airflow, recipes/flask-swagger, recipes/python-nvd3, recipes/python-slugify) and found it was in an excellent condition.

sodre added a commit to sodre/staged-recipes that referenced this pull request Apr 28, 2017
This is a requirement for the airflow PR conda-forge#2882
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airflow, recipes/flask-swagger, recipes/python-nvd3) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airflow, recipes/flask-swagger) and found it was in an excellent condition.

sodre added a commit to sodre/staged-recipes that referenced this pull request Apr 29, 2017
This is a requirement for the airflow PR conda-forge#2882
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airflow) and found it was in an excellent condition.

@sodre
Copy link
Member Author

sodre commented May 4, 2017

@conda-forge/core,
I need some input on how to handle the extra_requires for airflow. It is not a small-list so I don't think adding all of them to the recipe is the best choice. I know CIO is working on the establishing the "optional" requirements but while that does not arrive what have we done lately.

One possibility is to create several airflow- metapackages that brings in the additional dependencies. Is there a conda-forge example for that?

@mariusvniekerk
Copy link
Member

So for now i would try and get a minimal airflow recipe building fully on conda-forge.

Treating the additional dependencies as metapackages for now is probably the simplest approach. For a few of those sets of dependencies you are going to have to submit additional conda-forge packages in any case so it may be simpler for you to iterate that way?

@jakirkham
Copy link
Member

Have heard conda 4.4 has support for optional dependencies, but do not know how one would take advantage of this. Maybe ask at conda or conda-build how to use this.

@sodre
Copy link
Member Author

sodre commented May 11, 2017

In the short term I will go with @mariusvniekerk suggestion of a minimal airflow install. I will create an issue for the missing extra-packages for airflow and slowly create the associated metapackages.

The new feature in for handling optional dependencies in conda through meta.yaml is solved through conda/conda-build#2001. Once it becomes part of conda-forge we can augment the main recipe.

@sodre sodre changed the title [WIP] Add airflow 1.8.0 recipe to conda-forge. Add airflow 1.8.0 recipe to conda-forge. May 11, 2017
@sodre
Copy link
Member Author

sodre commented May 12, 2017

@conda-forge/core this is ready for review.

@ocefpaf ocefpaf merged commit 8c0326d into conda-forge:master May 12, 2017
@pmlandwehr
Copy link
Contributor

Congrats!

@sodre
Copy link
Member Author

sodre commented May 13, 2017

I need to start getting the add-ons done, or just wait for conda 4.4.

@sodre sodre deleted the airflow branch May 13, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants