Add recipe for itk #3263
Add recipe for itk #3263
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Todos:
|
recipes/itk/bld.bat
Outdated
| @@ -0,0 +1,2 @@ | |||
| %PYTHON% -m pip install --no-deps https://pypi.org/packages/cp35/t/tensorflow/tensorflow-%PKG_VERSION%-cp35-cp35m-win_amd64.whl | |||
There was a problem hiding this comment.
@thewtex I think you need to do the same thing here that we did for build.sh. But I have no idea how to do loops in windows batch scripts 🤷♂️
There was a problem hiding this comment.
Will push up the addition in the next version :-) 🎉
|
|
||
| about: | ||
| home: http://www.itk.org/ | ||
| license: Apache 2.0 |
There was a problem hiding this comment.
Is the license file bundled with the wheel on pypi? If so you can include a "license_file" key here in the about section with the path to the license file.
about:
license_file: LICENSE
...There was a problem hiding this comment.
Good point. A quick search, it looks like it does not get packed, though.
| about: | ||
| home: http://www.itk.org/ | ||
| license: Apache 2.0 | ||
| summary: ITK is an open-source toolkit for multidimensional image analysis |
There was a problem hiding this comment.
might want to include
about:
doc_url: https://itk.org/ITK/help/documentation.html
dev_url: https://github.com/InsightSoftwareConsortium/ITK
This re-uses the PyPI packages that wrap the Insight Toolkit (ITK). The infrastructure is based off the tensorflow conda recipe. Currently a monolithic package for "itk" in created. In the future, it is possible to splite it into an itk metapackage and multiple dependent packages, itk-core, itk-io, itk-segmentation, etc. Co-authored-by: Eric Dill <thedizzle@gmail.com>
|
@ericdill Thanks for the great review! 🥇 Locally built and testing with miniconda3 / Python 3.6 on Linux / macOS / Windows. |
|
The Mac OS X build is failing only because rustc is being built. All three itk builds succeed. I don't see any reason why this should be a blocker for merging since it is unrelated to the current recipe. |
|
Shoot, this is probably going to cause issues because of the existing itk-feedstock, conda-forge/itk-feedstock#8. Sorry, I'm catching up with my emails in reverse order and this one came first. Ping me if there is anything I can do to help fix this. |
|
@jjhelmus Regardless, for moving it forward. Could the the |
|
Renamed |
|
Thanks! Should we re-merge this branch to re-populate the |
This re-uses the PyPI packages. The infrastructure is based off the tensorflow
conda recipe.
Currently a monolithic package for "itk" in created. In the future, it is
possible to splite it into an itk metapackage and multiple dependent packages,
itk-core, itk-io, itk-segmentation, etc.
Co-authored-by: Eric Dill thedizzle@gmail.com
CC: @ericdill @jjhelmus @blowekamp @msarahan