Add Package dSFMT-2.2.3 #3965

dfornika · 2017-09-14T17:21:36Z

Addresses #3964.

conda-forge-linter · 2017-09-14T17:21:51Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dsfmt) and found some lint.

Here's what I've got...

For recipes/dsfmt:

The license item is expected in the about section.

conda-forge-linter · 2017-09-14T17:29:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dsfmt) and found it was in an excellent condition.

jakirkham · 2017-09-14T17:38:08Z

recipes/dsfmt/meta.yaml

+
+requirements:
+  build:
+    - gcc


Would change this to toolchain. We should be able to build this with the system included compilers I think.

jakirkham · 2017-09-14T17:38:31Z

recipes/dsfmt/meta.yaml

+
+build:
+  number: 0
+  script: build.sh


No need for this script line. conda-build does this automatically.

jakirkham · 2017-09-14T17:39:07Z

recipes/dsfmt/build.sh

+
+export CFLAGS="-I$PREFIX/include"
+export LDFLAGS="-L$PREFIX/lib"
+export CPATH=${PREFIX}/include


These should be handled by toolchain.

jakirkham · 2017-09-14T17:40:27Z

recipes/dsfmt/build.sh

+make std-check
+make sse2-check
+
+cp dSFMT.h ${PREFIX}/include


No make install? Is there a library or something that needs to be installed as well?

The Makefile doesn't have an install target. In the dsfmt.mk file in the julia repo I see that they build a library:

$(BUILDDIR)/dsfmt-$(DSFMT_VER)/build-compiled: $(BUILDDIR)/dsfmt-$(DSFMT_VER)/source-extracted cd $(dir $<) && \ $(CC) $(CPPFLAGS) $(DSFMT_CFLAGS) $(LDFLAGS) dSFMT.c -o libdSFMT.$(SHLIB_EXT)

But I don't see any way to build the library directly from the Makefile

That translates to roughly:

gcc -O3 -finline-functions -fomit-frame-pointer -DNDEBUG -DDSFMT_MEXP=19937 \ -fPIC -fno-strict-aliasing --param max-inline-insns-single=1800 -Wmissing-prototypes \ -Wall -std=c99 -shared dSFMT.c -o libdSFMT.so

Ok. Might need to create the directory first.

Alright, let's add it then. We may come back and tweak it later.

jakirkham · 2017-09-14T17:41:18Z

recipes/dsfmt/build.sh

+
+make std
+make std-check
+make sse2-check


No make check or make test step for all of these?

make check just makes a copy of a bash script check.sh and makes it executable

jakirkham · 2017-09-14T17:41:43Z

recipes/dsfmt/build.sh

+export LDFLAGS="-L$PREFIX/lib"
+export CPATH=${PREFIX}/include
+
+make std


What does this do? Is there a general make call for building?

Simply calling make has the same result as calling make std. It builds an executable called test-std-M19937

I see. So guess we need to build and install the library ourselves.

jakirkham · 2017-09-15T01:58:09Z

recipes/dsfmt/meta.yaml

+  license_file: LICENSE.txt
+  summary: 'Double precision SIMD-oriented Fast Mersenne Twister'
+
+  # The remaining entries in this section are optional, but recommended


Please drop comments held over from the example recipe.

jakirkham · 2017-09-15T01:59:18Z

recipes/dsfmt/build.sh

+
+gcc -O3 -finline-functions -fomit-frame-pointer -DNDEBUG -DDSFMT_MEXP=19937 \
+  -fPIC -fno-strict-aliasing --param max-inline-insns-single=1800 -Wmissing-prototypes \
+  -Wall -std=c99 -shared dSFMT.c -o libdSFMT.so


Please change .so to ${SHLIB_EXT}.

jakirkham · 2017-09-15T01:59:24Z

recipes/dsfmt/build.sh

+
+mkdir ${PREFIX}/lib
+mkdir ${PREFIX}/include
+cp libdSFMT.so ${PREFIX}/lib


Please change .so to ${SHLIB_EXT}.

jakirkham · 2017-09-15T02:00:28Z

recipes/dsfmt/meta.yaml

+  sha256: {{ sha256 }}
+
+build:
+  number: 0


Please add

skip: true # [win]

jakirkham · 2017-09-15T02:00:46Z

recipes/dsfmt/meta.yaml

+test:
+  commands:
+    - test -f "${PREFIX}/include/dSFMT.h"
+    - test -f "${PREFIX}/lib/libdSFMT.so"


Please change .so to ${SHLIB_EXT}.

tkelman · 2017-09-15T16:25:45Z

This is missing the patches that are needed by Julia to make the necessary functions externally visible from the shared library and use word-sized integer arguments.

dfornika · 2017-09-15T20:14:19Z

Thanks @tkelman I did make note of that in the issue on the julia-feedstock repo that suggests using this package:

conda-forge/julia-feedstock#21

jakirkham · 2017-09-15T23:00:32Z

Assuming we are referring to this patch and this patch. Have those patches been sent upstream, @tkelman?

jakirkham · 2017-09-15T23:03:40Z

recipes/dsfmt/build.sh

+  -Wall -std=c99 -shared dSFMT.c -o libdSFMT.${SHLIB_EXT}
+
+mkdir ${PREFIX}/lib
+mkdir ${PREFIX}/include


Normally I do mkdir -p just in case it is already there. Not that it would be in this case. We just don't want to waste time debugging something we are doing just in case these directories are not there.

jakirkham · 2017-09-15T23:19:14Z

Honestly this is looking pretty good. We still need to sort out the changes needed for Julia, but think this is largely in a good place.

tkelman · 2017-09-16T00:21:22Z

The last release from upstream was 4 years ago. The patches are about as old I suspect, would have to go hunting in blame to find who added them initially and if there was any discussion about upstreaming at the time. Didn't realize the code is hosted on github now too, so sending those as patches might be worthwhile if it wasn't done before.

isuruf · 2017-09-17T15:00:25Z

recipes/dsfmt/build.sh

+make std-check
+make sse2-check
+
+gcc -O3 -finline-functions -fomit-frame-pointer -DNDEBUG -DDSFMT_MEXP=19937 \


Use ${CC} here instead of gcc

jakirkham · 2017-09-18T15:38:19Z

recipes/dsfmt/meta.yaml

+test:
+  commands:
+    - test -f "${PREFIX}/include/dSFMT.h"
+    - test -f "${PREFIX}/lib/libdSFMT.${SHLIB_EXT}"


No need for a . here as SHLIB_EXT already has one.

jakirkham · 2018-08-21T01:48:08Z

Thanks @dfornika. Made a few small changes and merged to get this in. Hope that is ok. We can address anything else in the feedstock.

jakirkham · 2018-08-21T01:57:48Z

This is missing the patches that are needed by Julia to make the necessary functions externally visible from the shared library and use word-sized integer arguments.

Raised as issue ( conda-forge/dsfmt-feedstock#1 ) on the feedstock.

dfornika added 2 commits August 28, 2017 18:25

dSFMT Initial commit

4d534b0

Add maintainer, fix test

5aceae6

dfornika mentioned this pull request Sep 14, 2017

Pull dSFMT from conda-forge conda-forge/julia-feedstock#21

Open

Added license string

3e1db07

jakirkham reviewed Sep 14, 2017

View reviewed changes

dfornika added 3 commits September 14, 2017 10:54

Use toolchain to build

1351557

Build shared library

693bdb9

Added ${PREFIX}/include directory

9139f58

jakirkham reviewed Sep 15, 2017

View reviewed changes

recipes/dsfmt/meta.yaml Outdated

sha256: {{ sha256 }}

build:

number: 0

Copy link

Member

jakirkham Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

skip: true # [win]

jakirkham reviewed Sep 15, 2017

View reviewed changes

dfornika added 3 commits September 15, 2017 13:22

Removed comment from example recipe

829c2c9

Substituted 'so' for SHLIB_EXT

3431ebe

Skip windows build

c209cb8

jakirkham reviewed Sep 15, 2017

View reviewed changes

mkdir -p

abe0e90

isuruf reviewed Sep 17, 2017

View reviewed changes

Use CC instead of gcc

61ba35e

jakirkham reviewed Sep 18, 2017

View reviewed changes

dfornika and others added 6 commits September 18, 2017 10:05

Removed . before SHLIB_EXT

b2cf468

Switch to compiler syntax

30574ea

Merge branch 'conda-forge/master' into 'dfornika/dSFMT-2.2.3'

90dc231

Add CFLAGS and LDFLAGS

c446d15

Wrap lines

7776072

Wrap description

cbf825e

jakirkham changed the title ~~WIP: Add Package dSFMT-2.2.3~~ Add Package dSFMT-2.2.3 Aug 21, 2018

jakirkham merged commit 7af5fc9 into conda-forge:master Aug 21, 2018

jakirkham mentioned this pull request Aug 21, 2018

Applying Julia's patches conda-forge/dsfmt-feedstock#1

Open

jakirkham mentioned this pull request Sep 13, 2018

Add dSFMT #3964

Closed

dfornika deleted the dSFMT-2.2.3 branch September 13, 2018 05:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Package dSFMT-2.2.3 #3965

Add Package dSFMT-2.2.3 #3965

dfornika commented Sep 14, 2017

conda-forge-linter commented Sep 14, 2017

conda-forge-linter commented Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 14, 2017

dfornika Sep 14, 2017

dfornika Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 14, 2017

dfornika Sep 14, 2017

jakirkham Sep 14, 2017

dfornika Sep 14, 2017

jakirkham Sep 14, 2017

jakirkham Sep 15, 2017

jakirkham Sep 15, 2017

jakirkham Sep 15, 2017

jakirkham Sep 15, 2017

jakirkham Sep 15, 2017

tkelman commented Sep 15, 2017

dfornika commented Sep 15, 2017

jakirkham commented Sep 15, 2017

jakirkham Sep 15, 2017

jakirkham commented Sep 15, 2017

tkelman commented Sep 16, 2017

isuruf Sep 17, 2017

jakirkham Sep 18, 2017

jakirkham commented Aug 21, 2018

jakirkham commented Aug 21, 2018

Add Package dSFMT-2.2.3 #3965

Add Package dSFMT-2.2.3 #3965

Conversation

dfornika commented Sep 14, 2017

conda-forge-linter commented Sep 14, 2017

conda-forge-linter commented Sep 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkelman commented Sep 15, 2017

dfornika commented Sep 15, 2017

jakirkham commented Sep 15, 2017

Choose a reason for hiding this comment

jakirkham commented Sep 15, 2017

tkelman commented Sep 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Aug 21, 2018

jakirkham commented Aug 21, 2018