Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add a metapackage to select BLAS #525

Closed
wants to merge 6 commits into from
Closed

WIP: Add a metapackage to select BLAS #525

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd88ce6
blas_openblas: Add a metapackage to select OpenBLAS.
jakirkham May 2, 2016
d2344e9
blas: Revise based on suggestions from Michael Grant.
jakirkham May 3, 2016
d92f536
blas: No OpenBLAS on Windows yet. [skip appveyor]
jakirkham May 3, 2016
6958232
blas: Simplify recipe. [skip appveyor]
jakirkham May 3, 2016
b350e55
blas: Test for the variant.
jakirkham May 3, 2016
8bca163
blas: Test that the variant itself is present.
jakirkham May 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 27 additions & 0 deletions recipes/blas/meta.yaml
View file
Open in desktop
@@ -0,0 +1,27 @@
{% set variant = "openblas" %}

package:
name: blas
version: 1.0.0

build:
skip: true # [win]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No OpenBLAS on Windows yet.

string: {{ variant }}

requirements:
run:
- {{ variant }}

test:
commands:
- conda list -n _test blas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the environment here feels like a horrific hack and quite fragile. Unfortunately, not setting it runs into this issue ( conda/conda-build#910 ). So, not really sure there is another option ATM.

- conda list -n _test --json -f blas | grep "blas-.*-{{ variant }}"

about:
home: NA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add this pull url as a homepage. So that people see it later can read about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were thinking of adding some document to explain how this works and then linking to it. Though we can certainly consider linking from there to the PR.

license: NA
summary: Metapackage to select the BLAS `{{ variant }}`.

extra:
recipe-maintainers:
- jakirkham