New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda needs to activate _build and _test environments - not monkey with PATH #910
Comments
This is very related to your compiler configuration PR on conda-forge. IMHO, we need conda-build actually activating environments. That will both clean up code in conda-build, and make it more predictable. |
Also, this issue ( #355 ) seems to be related. |
Also, maybe this issue ( #353 ) too. |
Here is a use case for configuring compiler tools ( conda-forge/thrift-cpp-feedstock#4 ). Note that the |
Just so I know (as there is a 2.0.0beta out), is this still planned for 2.0.0? |
I forgot about it, but it fits. This is what prerelease is for! |
Awesome, that is very exciting. What do we need to do to make this work? |
Here's what I have so far:
Still need test cases that prove functionality. Have not run tests to see if this breaks anything. |
This branch has such a functions which I got from xonsh: https://github.com/janschulz/jupyter_environment_kernels/commits/conda_windows -> last two commits [I've currently no clue why the real repo, where that branch was PR to, has gone missing :-(] |
I would be glad to see this merged to 2.0 too 😄 |
@Juanlu001 this is in 1.21.0. It's a bit buggy. If you're comfortable installing from source, I'd appreciate your review and comments on #1044, which should hopefully clear up a lot of the errors. |
Great, I will try to provide some feedback this weekend. |
@msarahan I'm not about to reopen this, but I'm using latest I'm trying to build
My
And I assumed that would have @mingwandroid has checked and believes that |
The plot thickens! I have no idea how /home/ijstokes/.conda/envs/_build/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../libkrb5.so: undefined reference to `k5_get_error@krb5support_0_MIT'
/home/ijstokes/.conda/envs/_build/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../libkrb5.so: undefined reference to `k5_json_string_create_len@krb5support_0_MIT'
collect2: error: ld returned 1 exit status
make[3]: *** [test/unit/unit] Error 1
make[3]: Leaving directory `/home/ijstokes/conda-bld/work/pivotalrd-libhdfs3-2.2.31/build'
make[2]: *** [test/unit/CMakeFiles/unit.dir/all] Error 2
make[2]: Leaving directory `/home/ijstokes/conda-bld/work/pivotalrd-libhdfs3-2.2.31/build'
make[1]: *** [test/CMakeFiles/unittest.dir/rule] Error 2
make[1]: Leaving directory `/home/ijstokes/conda-bld/work/pivotalrd-libhdfs3-2.2.31/build'
make: *** [unittest] Error 2
Command failed: /bin/bash -x -e /home/ijstokes/conda-bld/work/pivotalrd-libhdfs3-2.2.31/conda_build.sh So I thought I'd dig around and what does $ cat /home/ijstokes/conda-bld/work/pivotalrd-libhdfs3-2.2.31/conda_build.sh
source activate /home/ijstokes/.conda/envs/_build
#!/usr/bin/env bash
export PROTOBUF_LIBRARY=$CONDA_PREFIX/lib
export PROTOBUF_INCLUDE_DIR=$CONDA_PREFIX/include
mkdir build
cd build
export LIBHDFS3_HOME=`pwd`
../bootstrap --prefix=$PREFIX
make
make unittest
make install So it appears that whatever it is that creates |
I looked a bit more carefully and I can see where it is done now, apologies for the misinformation: activate _test: activate _build (Windows): activate _build (Unix): |
I believe you should depend primarily on $PREFIX for things like this, which will always be the build environment prefix. $CONDA_PREFIX is brand new, and depends on a very up-to-date conda. Aside from that, it is much less tested. |
Hi there, thank you for your contribution! This issue has been automatically locked because it has not had recent activity after being closed. Please open a new issue if needed. Thanks! |
When using the following recipe.
I run the build, but it appears not to activate the
_test
environment during the testing phase, but remains in the_build
environment. Here is a snippet that I see in the log.The text was updated successfully, but these errors were encountered: