Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A matplotlib metapackage #6697

Closed
wants to merge 1 commit into from
Closed

A matplotlib metapackage #6697

wants to merge 1 commit into from

Conversation

marcelm
Copy link

@marcelm marcelm commented Sep 19, 2018

Now that matplotlib 3.0.0 has been released, I’d like to push forward the idea of splitting a matplotlib-core package that does not depend on pyqt off of matplotlib. This was discussed on conda-forge/matplotlib-feedstock#2 and conda-forge/matplotlib-feedstock#157. My suggestion was to rename matplotlib(-feedstock) to matplotlib-core(-feedstock), remove the pyqt dependency from it, and to add a matplotlib metapackage that depends on the new matplotlib-core and pyqt.

This pull request adds the metapackage, but could of course only be merged after the rename.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/matplotlib) and found some lint.

Here's what I've got...

For recipes/matplotlib:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • The recipe must have some tests.
  • Feedstock with the same name exists in conda-forge

@ocefpaf
Copy link
Member

ocefpaf commented Sep 19, 2018

@marcelm let us try the split-package approach instead of another feedstock. I add a comment on your mpl PR about that.

@ocefpaf ocefpaf closed this Sep 19, 2018
@marcelm
Copy link
Author

marcelm commented Sep 19, 2018

Thanks, I did not realize split packages would work for that. This will also make it easier to keep the version numbers in sync.

@marcelm marcelm deleted the matplotlib-meta branch September 19, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants