Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe hickle #7268

Merged
merged 11 commits into from
Jan 9, 2019
Merged

Add recipe hickle #7268

merged 11 commits into from
Jan 9, 2019

Conversation

telegraphic
Copy link
Contributor

This is a python package, so for review by @conda-forge/help-python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@telegraphic telegraphic reopened this Dec 13, 2018
@telegraphic
Copy link
Contributor Author

telegraphic commented Dec 13, 2018

@conda-forge/core -- first time attempting to add a recipe, not really sure what this error is about. Is there any documentation on how/where to add a linting recipe? (And may I suggest adding a link to this in the friendly automated conda-forge-linting message?)

@telegraphic telegraphic changed the title create hickle/meta.yaml Add recipe hickle Dec 13, 2018
@telegraphic
Copy link
Contributor Author

pinging @conda-forge/staged-recipes and @conda-forge/core for help!

@telegraphic telegraphic reopened this Dec 14, 2018
@telegraphic
Copy link
Contributor Author

@conda-forge-admin, please lint

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hickle) and found it was in an excellent condition.

@telegraphic
Copy link
Contributor Author

Ah, ok, I missed the renaming of the recipes/example folder, now its changed to recipes/hickle it looks like it's running.

Copy link
Member

@CJ-Wright CJ-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has deleted the examples file please do not merge until it has been restored

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (example, recipes/hickle) and found some lint.

Here's what I've got...

For example:

  • Feedstock with the same name exists in conda-forge

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hickle) and found it was in an excellent condition.

@telegraphic
Copy link
Contributor Author

@CJ-Wright , thanks, I have re-added the examples/meta.yaml file. Please let me know if there's more fix-ups to do.

@CJ-Wright CJ-Wright dismissed their stale review December 18, 2018 14:49

the examples are back

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment in the YAML. After that, this is good to merge!

recipes/hickle/meta.yaml Outdated Show resolved Hide resolved
@telegraphic
Copy link
Contributor Author

@beckermr and @CJ-Wright: happy new year! Just checking in on this?

@beckermr
Copy link
Member

beckermr commented Jan 9, 2019

Let's wait on @CJ-Wright to approve too!

@telegraphic
Copy link
Contributor Author

Thanks @beckermr! Will be good to tick this off my list :)

Copy link
Member

@CJ-Wright CJ-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckermr beckermr merged commit f8d68ae into conda-forge:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants