Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readd bob.ip.flandmark [skip appveyor] #751

Merged
merged 5 commits into from
Jul 9, 2016
Merged

readd bob.ip.flandmark [skip appveyor] #751

merged 5 commits into from
Jul 9, 2016

Conversation

183amir
Copy link
Contributor

@183amir 183amir commented Jun 9, 2016

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bob.ip.flandmark) and found it was in an excellent condition.

@jakirkham
Copy link
Member

I think this will be fixed once we have setuptools ( #749 ). Thus far, I'm not encountering this import error with it.

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

This is failing for good reasons! Setuptools is a runtime dependency of bob packages.

@jakirkham
Copy link
Member

Was just about to ask that. Why is that the case?

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

Because it uses pkg_resources!

@jakirkham
Copy link
Member

Sure, I'm just wondering what it does with it.

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

I remember in the early days, I had setuptools in runtime dependencies but you asked me to remove it. Since it was being pulled somehow, I ignored it and removed it.

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

when I was doing the first bob package, bob.extension.

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

It uses pkg_resources to handle 3 tier packages gracefully. All __init__.py files in bob packages use pkg_resources like this one: https://github.com/bioidiap/bob.extension/blob/master/bob/__init__.py
No. bob.extension uses it. So I should add it there.

@jakirkham
Copy link
Member

Agreed. That makes sense. Maybe we can do that first and come back here afterwards.

@183amir
Copy link
Contributor Author

183amir commented Jun 9, 2016

ok all green now. Could you please merge this?

export MACOSX_DEPLOYMENT_TARGET=10.9
export CFLAGS="${CFLAGS} -pthread"
export LDFLAGS="${LDFLAGS} -lpthread"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be replaced. Please see this PR ( conda-forge/thrift-cpp-feedstock#4 ) for how to change this.

@183amir
Copy link
Contributor Author

183amir commented Jun 19, 2016

@jakirkham adding toolchain here, breaks the builds on pyhon 3.4. Please take a look at the log of circleci. It builds fine for 2.7 but after that -m -m appears in the CFLAGS variable somehow.

@jakirkham
Copy link
Member

Could you please try pinning conda-build to version 1.20.3 on Linux? It looks like there is some sort of bug that snuck in? The problem appears to be reproducible with conda-build 1.21.0 and appears to go away with 1.20.3. Not sure what the causes is yet though.

@jakirkham
Copy link
Member

@msarahan, do you have any idea why this would happen?

@jakirkham
Copy link
Member

@msarahan, is working on a conda-build fix. Also, Travis CI is pretty backed up. Could we please hold on this for a bit to give him time to work on a fix and Travis CI to settle down?

@183amir
Copy link
Contributor Author

183amir commented Jun 22, 2016

Sure, but please don't cancel circle CI if possible.

@jakirkham
Copy link
Member

No worries. Not canceling anything.

@183amir
Copy link
Contributor Author

183amir commented Jul 8, 2016

@jakirkham this is finally building. Can we merge it now please?

@183amir 183amir merged commit fe9c1ae into conda-forge:master Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants