Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for imageio-ffmpeg #7730

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Conversation

almarklein
Copy link
Contributor

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/imageio-ffmpeg) and found it was in an excellent condition.

@almarklein
Copy link
Contributor Author

@conda-forge/help-python what's up with the windows CI?

2019-02-07T09:05:18.0947559Z Attempting to finalize metadata for imageio-ffmpeg
2019-02-07T09:05:18.2829930Z Traceback (most recent call last):
2019-02-07T09:05:18.2831437Z   File ".ci_support\build_all.py", line 130, in <module>
2019-02-07T09:05:18.2831644Z     build_all(args.recipes_dir, args.arch)
2019-02-07T09:05:18.2831813Z   File ".ci_support\build_all.py", line 68, in build_all
2019-02-07T09:05:18.2831996Z     build_folders(recipes_dir, new_comp_folders, arch, channel_urls)
2019-02-07T09:05:18.2832160Z   File ".ci_support\build_all.py", line 120, in build_folders
2019-02-07T09:05:18.2832349Z     conda_build.api.build(list(d.keys()), config=get_config(arch, channel_urls))
2019-02-07T09:05:18.2832536Z   File "C:\Miniconda\lib\site-packages\conda_build\api.py", line 208, in build
2019-02-07T09:05:18.2832701Z     notest=notest, need_source_download=need_source_download, variants=variants)
2019-02-07T09:05:18.2832879Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 2314, in build_tree
2019-02-07T09:05:18.2833037Z     notest=notest,
2019-02-07T09:05:18.2833199Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 1324, in build
2019-02-07T09:05:18.2834797Z     output_metas = expand_outputs([(m, need_source_download, need_reparse_in_env)])
2019-02-07T09:05:18.2834983Z   File "C:\Miniconda\lib\site-packages\conda_build\render.py", line 735, in expand_outputs
2019-02-07T09:05:18.2835167Z     for (output_dict, m) in _m.copy().get_output_metadata_set(permit_unsatisfiable_variants=False):
2019-02-07T09:05:18.2836350Z   File "C:\Miniconda\lib\site-packages\conda_build\metadata.py", line 2038, in get_output_metadata_set
2019-02-07T09:05:18.2836525Z     bypass_env_check=bypass_env_check)
2019-02-07T09:05:18.2836710Z   File "C:\Miniconda\lib\site-packages\conda_build\metadata.py", line 721, in finalize_outputs_pass
2019-02-07T09:05:18.2836873Z     permit_unsatisfiable_variants=permit_unsatisfiable_variants)
2019-02-07T09:05:18.2837041Z   File "C:\Miniconda\lib\site-packages\conda_build\render.py", line 509, in finalize_metadata
2019-02-07T09:05:18.2837217Z     exclude_pattern)
2019-02-07T09:05:18.2837383Z   File "C:\Miniconda\lib\site-packages\conda_build\render.py", line 371, in add_upstream_pins
2019-02-07T09:05:18.2837574Z     permit_unsatisfiable_variants, exclude_pattern)
2019-02-07T09:05:18.2837743Z   File "C:\Miniconda\lib\site-packages\conda_build\render.py", line 359, in _read_upstream_pin_files
2019-02-07T09:05:18.2837907Z     permit_unsatisfiable_variants=permit_unsatisfiable_variants)
2019-02-07T09:05:18.2838099Z   File "C:\Miniconda\lib\site-packages\conda_build\render.py", line 143, in get_env_dependencies
2019-02-07T09:05:18.2838262Z     channel_urls=tuple(m.config.channel_urls))
2019-02-07T09:05:18.2838429Z   File "C:\Miniconda\lib\site-packages\conda_build\environ.py", line 738, in get_install_actions
2019-02-07T09:05:18.2838606Z     locking=locking, timeout=timeout)
2019-02-07T09:05:18.2838786Z   File "C:\Miniconda\lib\site-packages\conda_build\index.py", line 241, in get_build_index
2019-02-07T09:05:18.2838963Z     platform=subdir)
2019-02-07T09:05:18.2839159Z   File "C:\Miniconda\lib\site-packages\conda\exports.py", line 243, in get_index
2019-02-07T09:05:18.2839358Z     index = _get_index(channel_urls, prepend, platform, use_local, use_cache, unknown, prefix)
2019-02-07T09:05:18.2839525Z   File "C:\Miniconda\lib\site-packages\conda\common\io.py", line 85, in decorated
2019-02-07T09:05:18.2839681Z     return f(*args, **kwds)
2019-02-07T09:05:18.2839856Z   File "C:\Miniconda\lib\site-packages\conda\core\index.py", line 58, in get_index
2019-02-07T09:05:18.2840025Z     index = fetch_index(channel_urls, use_cache=use_cache)
2019-02-07T09:05:18.2840202Z   File "C:\Miniconda\lib\site-packages\conda\core\index.py", line 73, in fetch_index
2019-02-07T09:05:18.2840359Z     sd = SubdirData(Channel(url))
2019-02-07T09:05:18.2840520Z   File "C:\Miniconda\lib\site-packages\conda\core\subdir_data.py", line 60, in __call__
2019-02-07T09:05:18.2840690Z     assert channel.subdir
2019-02-07T09:05:18.2840840Z AssertionError
2019-02-07T09:05:19.1595579Z ##[error]Cmd.exe exited with code '1'.
2019-02-07T09:05:19.1975489Z ##[section]Finishing: Build recipe (maybe vs2008)

recipes/imageio-ffmpeg/meta.yaml Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member

@conda-forge-admin, please rerender

@hoechenberger
Copy link
Member

@conda-forge/staged-recipes Could anyone please have a look why the Windows builds are failing?

@scopatz
Copy link
Member

scopatz commented Feb 7, 2019

You can ignore azure builds for the time being, but Circle is still failing.

@almarklein
Copy link
Contributor Author

Any idea what Circle is trying to tell us? This looks odd ...

+ conda clean --lock
ArgumentError: At least one removal target must be given. See 'conda clean --help'.

@hoechenberger
Copy link
Member

@almarklein Could you pull in latest staged-recipes:master and push again?

@almarklein
Copy link
Contributor Author

@hoechenberger done. (Is it correct that the recipes directory now contains 10 or so directories besides example and the imageio-ffmpeg that I added?)

@hoechenberger
Copy link
Member

hoechenberger commented Feb 10, 2019

@hoechenberger done. (Is it correct that the recipes directory now contains 10 or so directories besides example and the imageio-ffmpeg that I added?)

Great, thanks. Yes, this can happen – in fact, this fluctuates over time, you can ignore it.

@conda-forge/staged-recipes, I believe this PR is now good to be reviewed / merged.

PR to include license in sdist has been opened upstream: imageio/imageio-ffmpeg#11

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@beckermr beckermr merged commit 0aed706 into conda-forge:master Feb 10, 2019
@almarklein almarklein deleted the imageio-ffmpeg branch February 10, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants