Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECMWF cfgrib: open GRIB files with xarray #7837

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Add ECMWF cfgrib: open GRIB files with xarray #7837

merged 4 commits into from
Feb 25, 2019

Conversation

alexamici
Copy link
Contributor

@alexamici alexamici commented Feb 22, 2019

Hi, this recipe adds the ability to work with the very popular GRIB file format in xarray on Linux, MacOS and Windows (with the next release).

The need for a conda package is due to the eccodes dependency.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cfgrib) and found some lint.

Here's what I've got...

For recipes/cfgrib:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [45]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cfgrib) and found it was in an excellent condition.

@alexamici
Copy link
Contributor Author

@conda-forge/core this PR should be ready and safe to merge. Failures are the known issue #7715.

Copy link
Member

@chrisburr chrisburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of suggestions.

recipes/cfgrib/meta.yaml Outdated Show resolved Hide resolved
recipes/cfgrib/meta.yaml Outdated Show resolved Hide resolved
recipes/cfgrib/meta.yaml Outdated Show resolved Hide resolved
extra:
recipe-maintainers:
- alexamici
- StephanSiemen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephanSiemen Are you happy to be listed as maintainer of this recipe?

Copy link
Contributor Author

@alexamici alexamici Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say that I didn't explicitly ask him, but he is the head of the development section of ECMWF that commissioned to my company the development of cfgrib and we usually co-maintain all distribution channels.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's standard for us to check that any additional maintainers are happy before merging new recipes (most of the time it's a formality, but occasionally people say no).

If you'd like it be merged faster you can remove this line and re-add him in the feedstock (which you can edit directly).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am very happy to be added as a maintainer. Thanks @alexamici for the work!

chrisburr and others added 3 commits February 24, 2019 00:12
Co-Authored-By: alexamici <alexamici@gmail.com>
Co-Authored-By: alexamici <alexamici@gmail.com>
@chrisburr chrisburr merged commit 9d2055e into conda-forge:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants