Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ifcopenshell #8277

Merged
merged 22 commits into from
Jun 21, 2019
Merged

Ifcopenshell #8277

merged 22 commits into from
Jun 21, 2019

Conversation

looooo
Copy link
Contributor

@looooo looooo commented May 6, 2019

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages
  • Build number is 0
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ifcopenshell) and found some lint.

Here's what I've got...

For recipes/ifcopenshell:

  • The recipe must have some tests.
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ifcopenshell) and found some lint.

Here's what I've got...

For recipes/ifcopenshell:

  • The recipe must have some tests.
  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ifcopenshell) and found some lint.

Here's what I've got...

For recipes/ifcopenshell:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ifcopenshell) and found it was in an excellent condition.

@looooo
Copy link
Contributor Author

looooo commented Jun 1, 2019

@conda-forge/coris one should be ready
Edit: not yet. This is not yet using a release.

@looooo
Copy link
Contributor Author

looooo commented Jun 21, 2019

@conda-forge/core please review and merge.

@jjhelmus
Copy link
Contributor

LGTM

@jjhelmus jjhelmus merged commit eb2f51a into conda-forge:master Jun 21, 2019
@looooo
Copy link
Contributor Author

looooo commented Jun 21, 2019

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants