pymatgen #8888
pymatgen #8888
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pymatgen:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@scopatz I fixed the build script. From my perspective it is now ready to be merged. |
recipes/pymatgen/meta.yaml
Outdated
| build: | ||
| skip: true # [win or py<35] | ||
| number: 0 | ||
| script: "{{ PYTHON }} setup.py install --single-version-externally-managed --record record.txt" |
There was a problem hiding this comment.
Why not use the pip line as in the example?
There was a problem hiding this comment.
I was following the recommendation in https://github.com/conda-forge/staged-recipes/wiki/Frequently-asked-questions (8)
There was a problem hiding this comment.
I removed that recommendation. See https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip
|
@jan-janssen, that issue with setuptools building was because of the two recipes here. Can you please send a new PR for custodian? |
|
Issue is #6167 |
Done in #8893 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Thanks! |
| - pip | ||
| - setuptools >=18.0 | ||
| - cython | ||
| - numpy >=1.14.3 |
There was a problem hiding this comment.
This is wrong. This should be numpy 1.14.3
@conda-forge/help-python-c
I am aware there are other pull requests for pymatgen but all of them seem to be inactive:
This can only work, once conda-forge/monty-feedstock#12 is merged.
Checklist
url) rather than a repo (e.g.git_url) is used in yourrecipe (see
here
for more details)
Ps: I just noticed this is PR #8888 - I guess that means it is time to celebrate.