Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqsgenerator #8891

Merged
merged 17 commits into from Jul 23, 2019
Merged

sqsgenerator #8891

merged 17 commits into from Jul 23, 2019

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jul 21, 2019

@conda-forge/help-python-c

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your
    recipe (see
    here
    for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sqsgenerator) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

Waiting for #8888 to be merged

version: {{ version }}

source:
url: https://github.com/dnoeger/sqsgenerator/archive/master.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use master. Use a stable release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be stable, just a release that isn't an rc or pre-release

sha256: d58439c548433adcda98e695be53e526ba940a4b9c44fb9a05d92cd495cdd47f

build:
number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build number should be zero

@jan-janssen
Copy link
Member Author

@dnoeger Is it ok if I add you as a maintainer.

@dgehringer
Copy link

@jan-janssen yes of course, many thanks

@scopatz scopatz merged commit c1edc07 into conda-forge:master Jul 23, 2019
@scopatz
Copy link
Member

scopatz commented Jul 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants