Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ROOT #50

Merged
merged 6 commits into from
Oct 30, 2022
Merged

add ROOT #50

merged 6 commits into from
Oct 30, 2022

Conversation

KrisThielemans
Copy link
Contributor

try to add ROOT again (i.e. essentially the same as #17 but now with more recent STIR)

Fixes #20

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@KrisThielemans
Copy link
Contributor Author

@conda-forge-admin , please rerender

@KrisThielemans KrisThielemans mentioned this pull request Oct 29, 2022
Open
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [47]

@KrisThielemans
Copy link
Contributor Author

@conda-forge-admin , please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/stir-feedstock/actions/runs/3351189347.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@KrisThielemans KrisThielemans mentioned this pull request Oct 29, 2022
Closed
@KrisThielemans
Copy link
Contributor Author

Had to remove OSX support. See conda-forge/root-feedstock#191

@KrisThielemans
Copy link
Contributor Author

@conda-forge-admin , please rerender

@conda-forge conda-forge deleted a comment from github-actions bot Oct 29, 2022
conda-forge-webservices[bot] and others added 2 commits October 29, 2022 16:05
MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.21.2, and co…
566ad1a 
…nda-forge-pinning 2022.10.29.15.17.39
@KrisThielemans
use root_base also for testing
de4f990 
(and exclude OSX properly)
@KrisThielemans
Copy link
Contributor Author

@conda-forge-admin , please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/stir-feedstock/actions/runs/3352623499.

@KrisThielemans
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@KrisThielemans KrisThielemans merged commit 68d4ebd into conda-forge:main Oct 30, 2022
@KrisThielemans KrisThielemans deleted the addROOT branch October 30, 2022 08:44
This was referenced Oct 30, 2022
Closed
Closed
@KrisThielemans KrisThielemans mentioned this pull request Oct 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl casperdcl is a code owner

@olivierverdier olivierverdier Awaiting requested review from olivierverdier olivierverdier is a code owner

@paskino paskino Awaiting requested review from paskino paskino is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add ROOT support
2 participants
@KrisThielemans @conda-forge-linter