-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiledb-py v0.31.0 #226
base: main
Are you sure you want to change the base?
tiledb-py v0.31.0 #226
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to do two things:
- Bump tiledb pin to 2.25
- Migrate build system to scikit-build-core (see Test scikit-build-core tiledb-py #224)
ff5de75
to
1e99367
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current error is:
But those files are clearly in the source: https://github.com/TileDB-Inc/TileDB-Py/tree/0.31.0 Maybe they aren't being included in the PyPI source tarball? |
No. That's not it. wget https://pypi.io/packages/source/t/tiledb/tiledb-0.31.0.tar.gz
tar xzf tiledb-0.31.0.tar.gz
## tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'
## tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.macl'
## tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'
ls tiledb-0.31.0
## CMakeLists.txt HISTORY.md PKG-INFO ci doc external pyproject.toml tiledb
## CONTRIBUTING.md LICENSE README.md cmake examples misc setup.py |
Current status:
|
This is pretty weird because AFAIK we test if sdists can be installed: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/10099783077 |
But were any of those tested sdists uploaded to PyPI? AFAICT automatic upload to PyPI was disabled (TileDB-Inc/TileDB-Py#2020), and it wasn't re-enabled prior to tagging 0.31.0 https://github.com/TileDB-Inc/TileDB-Py/blob/0.31.0/.github/workflows/build-wheels.yml#L152 Was the PyPI upload done manually this time? Is that why I am seeing all the |
I think I found the source of the test failure The code itself was added 2 years ago: https://github.com/TileDB-Inc/TileDB-Py/blob/0.31.0/tiledb/tests/test_pandas_dataframe.py#L148 However, when that code was originally added, pd = pytest.importorskip("pandas") But that import was just removed yesterday in TileDB-Inc/TileDB-Py#2016 |
Also, I confirmed that pandas 2.2.2 was installed for the osx-64 builds, which should be compatible with TileDB-Py |
I was able to build the PyPI source tarball on locally on Ubuntu 22.04: wget https://pypi.io/packages/source/t/tiledb/tiledb-0.31.0.tar.gz
tar xzf tiledb-0.31.0.tar.gz
python -m venv ./build-pypi
mamba deactivate
source ./build-pypi/bin/activate
cd tiledb-0.31.0/
python -m pip install -v .
## Successfully installed numpy-2.0.1 tiledb-0.31.0 |
Confirmed that the linux-64 and win-64 jobs are failing because extracting the tarball results in a top-level directory ( |
And I confirmed the previous tarball does the exact same thing on linux: wget https://pypi.io/packages/source/t/tiledb/tiledb-0.30.0.tar.gz
tar xzf tiledb-0.30.0.tar.gz
ls
## tiledb-0.30.0 tiledb-0.30.0.tar.gz |
I'm baffled why this is happening. While it is likely due to a difference in the installed We could switch from As a sanity check, I ran {% set name = "tiledb" %}
{% set version = "0.31.0" %}
package:
name: {{ name|lower }}
version: {{ version }}
source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/tiledb-{{ version }}.tar.gz
sha256: 4e7fceb44e1e7ade6acfc22bd9085e5c6e2add5891ad268d4246b0265b17b0a1
build:
skip: true # [py<38]
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0 |
My only hope is that maybe if the next tarball we upload doesn't produce |
This was a mistake. I don't know what the purpose of
|
…nda-forge-pinning 2024.07.25.23.42.20
…nda-forge-pinning 2024.07.26.18.03.15
846a65a
to
365b722
Compare
* @dudoslav @ihnorton @jdblischak @johnkerl @kounelisagis @nguyenv @shelnutt2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These "errors" will go away once they accept the email invitation from GitHub to join this repository
It's not pretty, but I did manage to get green CI by:
|
128d9f3
to
19cd641
Compare
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: disabled
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.