vtk v9.0.0 #127

regro-cf-autotick-bot · 2020-05-02T01:13:07Z

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot.

The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

This PR was generated by https://circleci.com/gh/regro/circle_worker/16425, please use this URL for debugging}

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
boost-cpp	1.73.0
tbb	2020.2

conda-forge-linter · 2020-05-02T01:13:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar · 2020-05-02T07:45:52Z

@conda-forge-admin, please rerender

conda-forge-linter · 2020-05-02T07:46:18Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

xylar · 2020-05-02T07:46:29Z

@conda-forge-admin, please rerender

conda-forge-linter · 2020-05-02T07:49:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar · 2020-05-02T07:55:32Z

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in #105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

xylar · 2020-05-02T07:59:20Z

It looks like the release hasn't gone live yet at https://vtk.org/download/ and the hash is getting changed. I guess we'd better hold off on merging, but @jsbronder, it still would make sense to try to figure out TCL/TK.

xylar · 2020-05-02T10:05:50Z

@conda-forge/vtk, even though the release isn't posted yet on the VTK download page, it would be very good to get a review from as many of you as possible. Given that the release has already been tagged on the GitLab web page, I don't expect any remaining changes to affect the recipe other than the sha256.

looooo · 2020-05-02T19:19:45Z

it would be nice to try to avoid "build_env" prefixed paths in the cmake files. We saw some problems with this in vtk8.2: #86

xylar · 2020-05-02T19:26:11Z

@looooo, please edit the recipe and let's see how it goes.

looooo · 2020-05-02T19:53:51Z

I didn't find any "buid_env" prefixes in the cmake files of the vtk9.0.0.rc3 package. So I guess this is not a problem.

jsbronder · 2020-05-02T23:51:50Z

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in #105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

Will do, I'll take a look early next week.

jsbronder · 2020-05-05T01:01:46Z

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in #105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

Will do, I'll take a look early next week.

This all seems to work for me. I cloned vtk-feedstock and used the following script:

#!/usr/bin/env bash

topdir=$(dirname $(realpath -m $0))

export BUILD_CONFIG=Release
export PREFIX=${topdir}
export PY_VER=3
export SP_DIR=lib/python${PY_VER}/sites-packages

bash /home/jbronder/st/vtk-feedstock/recipe/build.sh

Once that completes I can:

PYTHONPATH=lib/python3.7/site-packages/ python -c 'import vtk.tk.vtkTkRenderWidget'

which all works. What exactly are you seeing fail?

xylar · 2020-05-05T06:59:47Z

@jsbronder, if it seems to be working, that's great! I had commented just before merging this PR to dev that I was disabling TK support: #105 (comment)
And since I am more or less bringing over that recipe, I thought that was still going to be the case here. I haven't had time to investigate further and am not able to do a non-osmesa build on my local machine so I haven't done any of my own testing.

jschueller · 2020-05-05T11:35:10Z

recipe/build.sh

+    -DVTK_MODULE_USE_EXTERNAL_vtkeigen:BOOL=ON \
+    -DVTK_MODULE_USE_EXTERNAL_vtkdoubleconversion:BOOL=ON \
+    -DVTK_MODULE_USE_EXTERNAL_vtklz4:BOOL=ON \
+    -DVTK_MODULE_USE_EXTERNAL_vtkzlib:BOOL=ON \


this is wrong, try VTK_MODULE_USE_EXTERNAL_zlib=ON
even better you can use VTK_USE_EXTERNAL=ON and disable only those that are not present (libharu, utf8)

@jschueller, I think the syntax changed with 9.0.0 but I could be wrong. I will try your suggestion. libharu is now available from conda-forge. I'm not sure about utf8 but I ended up with a list of 6 other packages that weren't on conda-forge yet and still had to be "vendored": #55 (comment)

By the way, I think you are more than welcome to be come a maintaner...

jschueller · 2020-05-05T11:36:39Z

recipe/build.sh

+    if [ "${OSNAME}" == Linux ]; then
+        VTK_ARGS+=(
+            "-DVTK_USE_X:BOOL=OFF"
+            "-DCMAKE_TOOLCHAIN_FILE=${RECIPE_DIR}/cross-linux.cmake"


why do you need a cross file ? CMAKE_PREFIX_PATH is usually enough

I'm happy to see if we can remove this. The CDAT folks seemed to think it was needed but I'm not sure if that's still true. @muryanto1?

xylar · 2020-05-05T12:02:22Z

recipe/build.sh

+    -DVTK_MODULE_USE_EXTERNAL_vtkzfp:BOOL=OFF \
+    -DVTK_MODULE_USE_EXTERNAL_vtkxdmf2:BOOL=OFF \
+    -DVTK_MODULE_USE_EXTERNAL_vtkxdmf3:BOOL=OFF \
+    -DVTK_MODULE_USE_EXTERNAL_vtkpegtl:BOOL=OFF \


@jschueller, this syntax isn't working Please let me know if you have further advice.

read the log again, it does work, now pegtl is required so either disable it or create a pegtl package

@jschueller, I certainly don't have time to make packages for these six libraries. My plan was to leave them vendored for now and hope that others do. That was what my syntax before was aiming to do.

as I said, this must be VTK_MODULE_USE_EXTERNAL_pegtl:BOOL=OFF, not VTK_MODULE_USE_EXTERNAL_vtkpegtl:BOOL=OFF

Okay, I'll give that a go.

This didn't appear to change the outcome. I don't have time to work on this further today. I would very much welcome help from others more knowledgeable about cmake! @jschueller, if you would prefer not to become a maintainer but want to throw up a test build of your own, I would certainly welcome that, too.

It seems I forgot an extra "VTK" in VTK_MODULE_USE_EXTERNAL_VTK_pegtl

xylar · 2020-05-09T11:48:36Z

@conda-forge-admin, please rerender

xylar · 2020-05-14T09:16:15Z

@conda-forge-admin, please rerender

MuellerSeb · 2020-05-19T12:22:40Z

Okay, and here's the answer to the first question:
https://gitlab.kitware.com/vtk/vtk/-/blob/master/ThirdParty/libharu/CMakeLists.txt#L8-10
VTK requires an unreleased version.

Seems like LibHaru needs a new maintainer (as written on their webpage)

xylar · 2020-05-29T11:03:22Z

Given that builds without mesalib are building correctly and I don't know what the problem is with the mesalib build, I'm going to disable the mesalib builds for now to get this merged.

These are the changes already tested on the `dev` branch over the last several months.

We have to because it requires an unreleased version

xylar · 2020-05-29T11:16:50Z

@conda-forge-admin, please rerender

…da-forge-pinning 2020.05.27.14.19.32

jschueller · 2020-05-29T12:20:36Z

bld.bat does not actually use external dependencies, the variables are misnamed, see build.sh:

-DVTK_USE_EXTERNAL:BOOL=ON \
    -DVTK_MODULE_USE_EXTERNAL_VTK_libharu:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_diy2:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_kzfp:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_pegtl:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_kissfft:BOOL=OFF \

by the way diy2, kzf and kissfft cannot be enabled via external use, so these are actually also useless from build.sh

xylar · 2020-05-29T13:06:46Z

Thanks for your ongoing advice, @jschueller. Does my last commit address your last comment?

I think I had meant to update bld.bat earlier once I was sure we had build.sh figured out but forgot. VTK isn't my highest priority, just trying to help out some colleagues who use it...

@jschueller

...based on suggestions from @jschueller

jschueller · 2020-05-29T13:28:42Z

perfect, for lzma I had to specify the path to the lib, see pv feedstock

following approach in paraview-feedstock

xylar · 2020-05-29T13:34:31Z

Thanks, that's a very helpful tip!

regro-cf-autotick-bot requested review from ccordoba12, dfroger, downiec, grlee77, ivoflipse, jasonb5, marcelotrevisani, Maxyme, msarahan, muryanto1, patricksnape, tadeu and xylar as code owners May 2, 2020 01:13

jschueller reviewed May 5, 2020

View reviewed changes

xylar reviewed May 5, 2020

View reviewed changes

xylar force-pushed the 9.0.0_hbc8ac4 branch from 23666cb to f696bb6 Compare May 14, 2020 09:16

xylar removed the request for review from ivoflipse May 14, 2020 09:25

regro-cf-autotick-bot and others added 10 commits May 29, 2020 13:04

updated v9.0.0

0a41a63

Update build changes based on dev

7c81b86

These are the changes already tested on the `dev` branch over the last several months.

Update sha256

8e5fd7b

Disable PNG test when VTK_WITH_OSMESA == True

281205f

Add one more tk-related test

a4e0554

Remove use of cross file

f3243b9

Switch to most libs external, 6 explicitly vendored

bf52bb7

Use vendored libharu

cac7bcf

We have to because it requires an unreleased version

Try removing vendored xdmf 2 and 3

cb1c828

Disable build with mesalib for now

77f0e66

xylar force-pushed the 9.0.0_hbc8ac4 branch from 1c18e81 to 77f0e66 Compare May 29, 2020 11:16

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.7.3, and con…

408df91

…da-forge-pinning 2020.05.27.14.19.32

Update external dependencies

c11d5c0

...based on suggestions from @jschueller

xylar force-pushed the 9.0.0_hbc8ac4 branch from 45ccb88 to c11d5c0 Compare May 29, 2020 13:07

Explicit path for LZMA

ed51da9

following approach in paraview-feedstock

xylar merged commit cb6ccc4 into conda-forge:master May 29, 2020

regro-cf-autotick-bot deleted the 9.0.0_hbc8ac4 branch May 29, 2020 18:29

banesullivan mentioned this pull request Nov 6, 2020

Build with xdmf #66

Closed

gdevenyi mentioned this pull request Nov 22, 2021

osmesa/mesalib no longer available #223

Closed

vtk v9.0.0 #127

vtk v9.0.0 #127

Conversation

regro-cf-autotick-bot commented May 2, 2020 • edited by xylar

conda-forge-linter commented May 2, 2020

xylar commented May 2, 2020

conda-forge-linter commented May 2, 2020

xylar commented May 2, 2020

conda-forge-linter commented May 2, 2020

xylar commented May 2, 2020

xylar commented May 2, 2020 • edited

xylar commented May 2, 2020

looooo commented May 2, 2020

xylar commented May 2, 2020

looooo commented May 2, 2020

jsbronder commented May 2, 2020

jsbronder commented May 5, 2020

xylar commented May 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xylar commented May 9, 2020

xylar commented May 14, 2020

MuellerSeb commented May 19, 2020

xylar commented May 29, 2020

xylar commented May 29, 2020

jschueller commented May 29, 2020 • edited

xylar commented May 29, 2020 • edited

jschueller commented May 29, 2020

xylar commented May 29, 2020

regro-cf-autotick-bot commented May 2, 2020 •

edited by xylar

xylar commented May 2, 2020 •

edited

jschueller commented May 29, 2020 •

edited

xylar commented May 29, 2020 •

edited