Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warpx v21.03 #11

Merged
merged 29 commits into from
Mar 5, 2021
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/612070158, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • orange3
  • gitpython
  • scipy
  • pandas
  • sphinx_rtd_theme
  • requests
  • matplotlib
  • yt
  • libensemble
  • python-configuration
  • numpy
  • periodictable
  • mpi4py

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ax3l ax3l self-assigned this Mar 2, 2021
@ax3l ax3l force-pushed the 21.03_hccfce6 branch 3 times, most recently from 67613a8 to 96fcbf1 Compare March 2, 2021 07:56
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

- remove hard-coded dependencies
- add pywarpx (PICMI) interface package
Clean the build dir in between builds on Windows.
Otherwise we get link issues, usually picking up a prior
build lib with different geometry from the build dir.
@ax3l ax3l added the enhancement New feature or request label Mar 2, 2021
@ax3l ax3l force-pushed the 21.03_hccfce6 branch 4 times, most recently from 3084e10 to 1903885 Compare March 2, 2021 22:57
@ax3l
Copy link
Member

ax3l commented Mar 3, 2021

I don't understand where I am going wrong, I tried setting AR, RANLIB, NM, LINKER and still get issues with clang-cl as soon as I start to also build a shared lib.
https://github.com/conda-forge/clang-win-activation-feedstock/blob/724a3900c88ef1748a9c1d90d0c2927db99c3ef5/recipe/activate-clang_win-64.bat#L3-L8

@isuruf do you have magic hints? I cannot find further examples in CF than the one above to derive from.

recipe/bld.bat Outdated Show resolved Hide resolved
@ax3l
Copy link
Member

ax3l commented Mar 4, 2021

Oh no, once I add python on Windows it pulls intel-openmp which conflicts with llvm-openmp we use with clang-cl.

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::intel-openmp-2020.3-h57928b3_311, conda-forge/win-64::llvm-openmp-11.0.1-h2d74725_0
  path: 'library/bin/libiomp5md.dll'

Should/can one use intel-openmp with clang-cl?
Update: seems this does not work:

CMake Error at D:/bld/warpx_1614885902861/_build_env/Library/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)

Update: oh, that was just a warning. intel-openmp does not work, but it's not needed. The build failed because I did not re-enable openPMD output yet and a file naming check caught that.

@ax3l ax3l force-pushed the 21.03_hccfce6 branch 2 times, most recently from abe10d3 to f026097 Compare March 4, 2021 23:00
@conda-forge conda-forge deleted a comment from conda-forge-linter Mar 4, 2021
Skip for RZ since BLAS++ & LAPACK++ are not yet packaged in
conda-forge.
@ax3l
Copy link
Member

ax3l commented Mar 5, 2021

@conda-forge-admin, please rerender

recipe/bld.bat Outdated Show resolved Hide resolved
@ax3l
Copy link
Member

ax3l commented Mar 5, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

ax3l added 2 commits March 4, 2021 19:34
```
[234/235] cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\app.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\mt.exe --manifests  -- %BUILD_PREFIX%\Library\bin\lld-link.exe  @CMakeFiles\app.rsp  /out:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console  && cmd.exe /C "cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe D:/bld/warpx_1614915530525/work/build/bin/warpx""
FAILED: bin/warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe
cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\app.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100177~1.0\x64\mt.exe --manifests  -- %BUILD_PREFIX%\Library\bin\lld-link.exe  @CMakeFiles\app.rsp  /out:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console  && cmd.exe /C "cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe D:/bld/warpx_1614915530525/work/build/bin/warpx""
LINK Pass 1: command "%BUILD_PREFIX%\Library\bin\lld-link.exe @CMakeFiles\app.rsp /out:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console /MANIFEST /MANIFESTFILE:CMakeFiles\app.dir/intermediate.manifest CMakeFiles\app.dir/manifest.res" failed (exit code 1) with the following output:
lld-link: error: could not open 'm.lib': no such file or directory
```
@ax3l ax3l merged commit 5108383 into conda-forge:master Mar 5, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 21.03_hccfce6 branch March 5, 2021 08:07
@ax3l
Copy link
Member

ax3l commented Mar 5, 2021

Can enable FFTW/PSATD on Windows once conda-forge/fftw-feedstock#75 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants