Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.3 #132

Merged
merged 47 commits into from
Dec 20, 2023
Merged

Release 2.0.3 #132

merged 47 commits into from
Dec 20, 2023

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Sep 14, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@PrimozGodec
Copy link
Contributor Author

@conda-forge-admin, please rerender

@PrimozGodec PrimozGodec reopened this Sep 18, 2023
@PrimozGodec
Copy link
Contributor Author

@conda-forge-admin, please rerender

@aldanor
Copy link
Contributor

aldanor commented Sep 24, 2023

Lots of failures here... cuda builds are failing like

$SRC_DIR/src/common/hist_util.cu(145): error: no instance of function template "thrust::make_zip_iterator" matches the argument list
            argument types are: (xgboost::Entry *, float *)

$SRC_DIR/src/common/hist_util.cu(146): error: no instance of function template "thrust::make_zip_iterator" matches the argument list
            argument types are: (xgboost::Entry *, float *)

$SRC_DIR/src/common/hist_util.cu(147): error: no instance of overloaded function "dh::SegmentedUnique" matches the argument list
            argument types are: (size_t *, size_t *, <error-type>, <error-type>, size_t *, <error-type>, lambda [](const Pair &, const Pair &)->__nv_bool)

Also OSX builds are failing

In file included from $SRC_DIR/src/c_api/c_api.cc:28:
$SRC_DIR/src/c_api/../data/proxy_dmatrix.h:137:25: error: 'any_cast<std::shared_ptr<xgboost::data::CSRArrayAdapter>>' is unavailable: introduced in macOS 10.13 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
      auto value = std::any_cast<std::shared_ptr<CSRArrayAdapter>>(proxy->Adapter());
                        ^
$BUILD_PREFIX/bin/../include/c++/v1/any:638:12: note: 'any_cast<std::shared_ptr<xgboost::data::CSRArrayAdapter>>' has been explicitly marked unavailable here
_ValueType any_cast(any && __v)
           ^
In file included from $SRC_DIR/src/c_api/c_api.cc:28:
$SRC_DIR/src/c_api/../data/proxy_dmatrix.h:145:25: error: 'any_cast<std::shared_ptr<xgboost::data::ArrayAdapter>>' is unavailable: introduced in macOS 10.13 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
      auto value = std::any_cast<std::shared_ptr<ArrayAdapter>>(proxy->Adapter())->Value();
                        ^
$BUILD_PREFIX/bin/../include/c++/v1/any:638:12: note: 'any_cast<std::shared_ptr<xgboost::data::ArrayAdapter>>' has been explicitly marked unavailable here
_ValueType any_cast(any && __v)
           ^
In file included from $SRC_DIR/src/c_api/c_api.cc:28:
$SRC_DIR/src/c_api/../data/proxy_dmatrix.h:148:25: error: 'any_cast<std::shared_ptr<xgboost::data::ArrayAdapter>>' is unavailable: introduced in macOS 10.13 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
      auto value = std::any_cast<std::shared_ptr<ArrayAdapter>>(proxy->Adapter());
                        ^
$BUILD_PREFIX/bin/../include/c++/v1/any:638:12: note: 'any_cast<std::shared_ptr<xgboost::data::ArrayAdapter>>' has been explicitly marked unavailable here
_ValueType any_cast(any && __v)
           ^

@elgalu

This comment was marked as off-topic.

@hcho3
Copy link
Contributor

hcho3 commented Oct 6, 2023

Let me try to take a look when I get back from vacation (next Tuesday)

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/6555152827.

Manually set these environment variables as `conda-build` doesn't set
these for `outputs`. Do this to ensure `pip` behaves correctly in the
`conda-build` environment.
@hcho3 hcho3 changed the title Release 2.0.0 Release 2.0.1 Nov 1, 2023
@hcho3
Copy link
Contributor

hcho3 commented Nov 2, 2023

@jakirkham Can I get a review? The CI is now all green.

@PrimozGodec
Copy link
Contributor Author

PrimozGodec commented Nov 17, 2023

@hcho3, thank you for the fixes. I just solved the conflict with the main branch.

I would be very happy if someone could review that soon to make version 2 available on conda-forge.

@jayqi
Copy link

jayqi commented Dec 8, 2023

Hi @jakirkham, @hcho3, @PrimozGodec. It's been a few weeks since the last activity, and I was hoping to check if any of you might have an update on when this release might be completed.

@hcho3
Copy link
Contributor

hcho3 commented Dec 15, 2023

Can I get another round of review? CI is all green.

@jakirkham
Copy link
Member

Thanks Philip! 🙏

Yes can look tomorrow

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of flags seems to be duplicated here, they should only be in one place.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/conda_build_config.yaml Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@hcho3
Copy link
Contributor

hcho3 commented Dec 15, 2023

@conda-forge-admin , please re-render

@hcho3
Copy link
Contributor

hcho3 commented Dec 15, 2023

@xhochy I addressed all your comments. Can you look and see if the changes look reasonable?

@hcho3 hcho3 changed the title Release 2.0.2 Release 2.0.3 Dec 20, 2023
@xhochy xhochy merged commit 91705f4 into conda-forge:main Dec 20, 2023
16 checks passed
@PrimozGodec PrimozGodec deleted the release-2.0.0 branch January 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants