Build with rockstar support on Linux #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cphyc
force-pushed
the
build-with-rockstar-support
branch
from
93d5879
to
7965b87
Compare
|
@neutrinoceros, the required PR #219 has now been merged. Do we need to rerun the checks here? If so, do you remember how? |
|
There's no need to rerun anything. The version that's being installed is 1.1.2 which does not include yt-project/yt_astro_analysis#219. This is why a patch essentially backports it to autodetect rockstar. NOTE: we check that rockstar is correctly built and linked, see https://github.com/conda-forge/yt_astro_analysis-feedstock/pull/14/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR43 |
neutrinoceros
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the feedstock so that it builds with rockstar support on Linux by default.
Requires yt-project/yt_astro_analysis#219 to be merged first.