Support installation of rockstar through conda #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
force-pushed
the
support-rockstar-conda
branch
from
5041cd5
to
ceea441
Compare
neutrinoceros
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Looks solid to me, but I'll leave @brittonsmith time to review it too !
brittonsmith
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rockstar can now be installed through conda. This simplifies the installation process as it needs not be compiled manually.
Eventually on Linux, we may want (or not?) to set rockstar as a hard dependency on our conda-forge build so that the support is automatic.