Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with LZ4 compression #13

Merged
merged 13 commits into from
Aug 6, 2019
Merged

Conversation

constantinpape
Copy link
Contributor

@constantinpape constantinpape commented May 13, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@constantinpape
Copy link
Contributor Author

@conda-forge-admin, please rerender

@constantinpape
Copy link
Contributor Author

@conda-forge-admin, please re-render

recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

@jakirkham
Copy link
Member

There seems to be an issue with a missing Boost symbol. Not sure what is causing that.

undefined symbol: _ZN5boost10filesystem6detail18create_directoriesERKNS0_4pathEPNS_6system10error_codeE

ref: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=41376

@constantinpape
Copy link
Contributor Author

There seems to be an issue with a missing Boost symbol. Not sure what is causing that.

Ok, I will see if I can reproduce this locally with boost 1.70.

@constantinpape
Copy link
Contributor Author

I have the same issue when building with boost 1.70 locally (Ubuntu 18, gcc 7.3). I will see if it build with 1.69 etc. tomorrow. Maybe the diff between recipes for the boost versions is helpful.

@jakirkham
Copy link
Member

Would it make sense to just pin to the last working version of Boost to get this in and then mess with upgrading Boost separately?

@constantinpape
Copy link
Contributor Author

Would it make sense to just pin to the last working version of Boost to get this in and then mess with upgrading Boost separately?

Makes sense. I pinned to 1.69, which works for me locally and will make an issue to keep track of 1.70 later.

@jakirkham
Copy link
Member

Looks like it is running into some issues finding the LZ4 libraries on Windows. Perhaps CMake needs additional guidance here?

@constantinpape constantinpape mentioned this pull request Jun 10, 2019
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

(To handle the fact that boost-cpp is now pinned.)

recipe/meta.yaml Outdated Show resolved Hide resolved
conda-forge-admin and others added 4 commits June 10, 2019 22:52
Co-Authored-By: jakirkham <jakirkham@gmail.com>
In order to fix windows build, that does not find LZ4, on conda-forge.
@constantinpape constantinpape mentioned this pull request Aug 5, 2019
3 tasks
@constantinpape
Copy link
Contributor Author

I think all issues are fixed (although in a bit of a hacky way, see #17).
However, the azure windows build is still failing, while the appveyor build went through.

@jakirkham Will conda-forge use the version built by appveyor if I merge this?

For reference, this is the azure traceback:

CMake Error at CMakeLists.txt:5 (project):
  Failed to run MSBuild command:

    MSBuild.exe

  to get the value of VCTargetsPath:

    Microsoft (R) Build Engine version 4.8.3761.0
    [Microsoft .NET Framework, version 4.0.30319.42000]
    Copyright (C) Microsoft Corporation. All rights reserved.
    
    Build started 8/5/2019 4:21:46 PM.
    Project "D:\bld\z5py_1565021703104\work\build\CMakeFiles\3.15.0\VCTargetsPath.vcxproj" on node 1 (default targets).
-- Configuring incomplete, errors occurred!
See also "D:/bld/z5py_1565021703104/work/build/CMakeFiles/CMakeOutput.log".
    D:\bld\z5py_1565021703104\work\build\CMakeFiles\3.15.0\VCTargetsPath.vcxproj(15,2): error MSB4019: The imported project "D:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
    Done Building Project "D:\bld\z5py_1565021703104\work\build\CMakeFiles\3.15.0\VCTargetsPath.vcxproj" (default targets) -- FAILED.
    
    Build FAILED.
    
    "D:\bld\z5py_1565021703104\work\build\CMakeFiles\3.15.0\VCTargetsPath.vcxproj" (default target) (1) ->
      D:\bld\z5py_1565021703104\work\build\CMakeFiles\3.15.0\VCTargetsPath.vcxproj(15,2): error MSB4019: The imported project "D:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
    
        0 Warning(s)
        1 Error(s)
    
    Time Elapsed 00:00:00.68
    

  Exit code: 1

@jakirkham
Copy link
Member

The Windows Azure failures can be ignored. This is a known issue. We are still using AppVeyor for Windows builds for this reason, which appears to pass here.

@constantinpape constantinpape merged commit 277114d into conda-forge:master Aug 6, 2019
@constantinpape
Copy link
Contributor Author

Ok, got it.
Thanks for the help @jakirkham.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants