-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with LZ4 compression #13
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2019.05.11
@conda-forge-admin, please re-render |
…da-forge-pinning 2019.06.09
@conda-forge-admin, please re-render. |
…da-forge-pinning 2019.06.09
There seems to be an issue with a missing Boost symbol. Not sure what is causing that.
ref: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=41376 |
Ok, I will see if I can reproduce this locally with boost 1.70. |
I have the same issue when building with boost 1.70 locally (Ubuntu 18, gcc 7.3). I will see if it build with 1.69 etc. tomorrow. Maybe the diff between recipes for the boost versions is helpful. |
Would it make sense to just pin to the last working version of Boost to get this in and then mess with upgrading Boost separately? |
Makes sense. I pinned to 1.69, which works for me locally and will make an issue to keep track of 1.70 later. |
Looks like it is running into some issues finding the LZ4 libraries on Windows. Perhaps CMake needs additional guidance here? |
@conda-forge-admin, please re-render. (To handle the fact that |
…da-forge-pinning 2019.06.09
Co-Authored-By: jakirkham <jakirkham@gmail.com>
In order to fix windows build, that does not find LZ4, on conda-forge.
I think all issues are fixed (although in a bit of a hacky way, see #17). @jakirkham Will conda-forge use the version built by appveyor if I merge this? For reference, this is the azure traceback:
|
The Windows Azure failures can be ignored. This is a known issue. We are still using AppVeyor for Windows builds for this reason, which appears to pass here. |
Ok, got it. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)