Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #13

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3500138862, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kjappelbaum
Copy link
Contributor

kjappelbaum commented Dec 12, 2022

It builds ok on m1 (the error in the CI might be due to cross-compilation issues), the test failures seem to be (locally, using mambabuild) due to lsmo-epfl/zeopp-lsmo#6 (again a domain and voronoi volume mismatch).

If I compile it completely manually on M1 there is no test issue (using Eigen 3.4 installed using homebrew).

The osx failure in the CI seems to be when computing the PSD

@ltalirz
Copy link
Member

ltalirz commented Dec 12, 2022

The test failure on OSX Intel were introduced when unpinning the Eigen library and would be good to fix
image

Opened #14 for this

Concerning the ARM build: the error is in the test suite

run_tests.sh: line 18: /Users/runner/miniforge3/conda-bld/zeopp-lsmo_1670833435768/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin/network: Bad CPU type in executable

Unless there is support for "cross-testing" (I doubt it; then they would not need to cross-compile), I think we'll need to disable the test suite for arm-osx for the time being

@kjappelbaum
Copy link
Contributor

kjappelbaum commented Dec 12, 2022

I think we'll need to disable the test suite for arm-osx for the time being

thanks, did this (I think)

The test failure on OSX Intel were introduced when unpinning the Eigen library and would be good to fix

I'm currently trying to understand the issues as I get different errors for different ways of compiling it

@ltalirz
Copy link
Member

ltalirz commented Dec 12, 2022

I see.

Maybe the cross-compiler doesn't like one of these options
https://github.com/lsmo-epfl/zeopp-lsmo/blob/d8f952a441f87bed04cf3beef51db80c07d41552/zeo%2B%2B/Makefile#L7-L16

You may also want to try running voro++ on CI first, to check whether the issue is localized to zeo++

@kjappelbaum kjappelbaum linked an issue Dec 19, 2022 that may be closed by this pull request
1 task
@kjappelbaum kjappelbaum merged commit 4d93d62 into conda-forge:main Dec 19, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_h9c6a2d branch December 19, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix osx x86_64 build
4 participants