Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds script_env support #65

Merged
merged 13 commits into from
Jun 3, 2024
Merged

Adds script_env support #65

merged 13 commits into from
Jun 3, 2024

Conversation

schuylermartin45
Copy link
Collaborator

@schuylermartin45 schuylermartin45 commented May 24, 2024 •
edited
Loading

  • Adds basic support for upgrading a recipe that contains a script_env section.
    • NOTE: There is one edge case that is not currently supported and is likely best left for a human to fix. The conversion process will flag this with an error.
  • Adds unit tests

Fixes #64

@schuylermartin45
Adds some missing build section transforms
4010ae4
@schuylermartin45
Improves deprecated field system by moving the logic to one function
dd22227
@schuylermartin45
Modifies unit tests to handle messaging changes
f668ab4
@schuylermartin45
Redacts license family from the conda recipe so the conversion build …
805941c 
…test passes without warnings
@schuylermartin45
Conversion process will no longer emit an emtpy context object
c3bc1ae
@schuylermartin45
Ensures canonical ordering of the Python test element
682afaa
@schuylermartin45
Preserves insert-order for patch add ops
47e13a0
@schuylermartin45
Adds in missing import; caused by bad git parts command
54f287b
@schuylermartin45
Makes pre-commit happy
dc2607f
@schuylermartin45
Adds support for upgrading _most_ script_env situations
6b6712c 
- The conversion tooling can now upgrade _most_ situations where `script_env`
  is present.
- We cannot easily upgrade scenarios where an environment variable is specified
  with a value with a selector. That will require manual intervention for now
@schuylermartin45
Adds unit tests for script-env work
81c2588
@schuylermartin45
Adds known edge case that is not currently supported into the unit te…
8bd0ae3 
…sting to ensure failure is handled correctly
@schuylermartin45
Merge branch 'main' of github.com:conda-incubator/conda-recipe-manage…
004dde7 
…r into smartin_script_env_support
@schuylermartin45 schuylermartin45 requested a review from a team as a code owner May 24, 2024 12:49
beeankha
beeankha reviewed Jun 3, 2024
View reviewed changes
conda_recipe_manager/parser/_utils.py
def set_key_conditionally(dictionary: dict[str, JsonType], key: str, value: JsonType) -> None:
"""
Convenience function that conditionally includes a key-value pair in a dictionary if the value is truthy.
Great for cheating McCabe ratings in complex JSON/YAML operations!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@schuylermartin45 schuylermartin45 merged commit 3c69a06 into main Jun 3, 2024
11 checks passed
@schuylermartin45 schuylermartin45 deleted the smartin_script_env_support branch June 3, 2024 19:05
@schuylermartin45 schuylermartin45 mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/build/script needs to be upgraded
2 participants
@schuylermartin45 @beeankha