-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] major refactor of downloads, environment creation #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* major refactor of downloads, environment creation
Hi @bollwyvl as always thanks for this. This is a bit too much for a single PR so if we could split this, that would be great. Also less chance of breaking things. Question what is the deal with underscored files? |
Just for sorting. could be changed.
Sure, fair. Will add a top-level plan of action... |
This was referenced Nov 22, 2020
bollwyvl
added a commit
to bollwyvl/setup-miniconda
that referenced
this pull request
Nov 29, 2020
goanpeca
added a commit
that referenced
this pull request
Dec 18, 2020
[1 of #107] Split up setup.ts
bollwyvl
added a commit
to bollwyvl/setup-miniconda
that referenced
this pull request
Dec 19, 2020
bollwyvl
added a commit
to bollwyvl/setup-miniconda
that referenced
this pull request
Dec 19, 2020
bollwyvl
added a commit
to bollwyvl/setup-miniconda
that referenced
this pull request
Dec 19, 2020
bollwyvl
added a commit
to bollwyvl/setup-miniconda
that referenced
this pull request
Dec 19, 2020
goanpeca
pushed a commit
that referenced
this pull request
Dec 19, 2020
This was referenced Dec 20, 2020
goanpeca
pushed a commit
that referenced
this pull request
Dec 20, 2020
* adopt dynamic options pattern, with temporary condaConfig * collapse additional type imports
This was referenced Dec 21, 2020
goanpeca
pushed a commit
that referenced
this pull request
Dec 24, 2020
* move variable and step output to common outputs * refactor more conda pieces, clean up imports * extract env parsing and installation to dedicated files * sweep of comment capitalization, add some comments, shouty-case provider lists
goanpeca
pushed a commit
that referenced
this pull request
Dec 24, 2020
* move base env tool providers to dedicated files * add some more log output for mamba bash * more work on mamba log output * use namespace import for constants, fix comment typos * fix windows path in mamba wrapper, add explit error throwing * ignore channel config warning, add a canary for the timestamp in log
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prelude to #75/#76, we talked about splitting out the downloader pieces into smaller things.
This is that... and entirely too much else. I basically couldn't track where all the
if
statements were going, and this is what I came up with to make future providers of installers more tractable... micromamba wouldn't look like what's in there, but we'll get there when we get there, I guess.inputs
(as from the yaml, this could still be improveduseMamba
, the parsed env file)any
types(Error|Success)Result
pattern, leaning almost entirely onthrow
and one top-levelcatch
(except around settings)Anyhow... I would worry about this bitrotting pretty fast, as any other features/fixes change, but it's also going to be a bear to review. So sorry! I can try to pull it apart into smaller incremental pieces, but basically did the whole thing in one go when my network was patchy.
Sub-PR Plan
.gitattributes
fordist
to be binary... it's never worth reviewingResult
to nativethrow