utilize chardet and bs4 to guess file encoding #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution looks nice. Thanks for digging into this one. This is the first case, at least that I can recall, of having encoding issues when building a recipe. Certainly will let you know if others crop up. I think the weird characters are supposed to specify terminal colors FYI. So don't think encoding is the issue in that case, but something else. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1632
Chardet enhances bs4. It is not directly imported.
Not sure if there's anywhere else that also needs this encoding guessing. @jakirkham if you are aware of other recipes that are broken with encoding errors, please let me know.
@tarcisiofischer this works, sort of. I can build the package, but the tests fail with some weird characters:
Not sure if that's related, or just an artifact. Sometimes that stuff shows up with bash involved.