Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial artifact signing code #3758

Closed
wants to merge 8 commits into from

Conversation

awwad
Copy link

@awwad awwad commented Oct 7, 2019

Draft of code to perform artifact signing during indexing.

Please note that the authenticate.py module will not be included in the final conda-build code, as it will instead be imported via conda.exports (from conda.common.authenticate).

construction.

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
If conda-build changes the way it serializes repodata at all,
conda needs to hash it differently.

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Oct 7, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @awwad. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@cla-bot
Copy link

cla-bot bot commented Oct 8, 2019

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @awwad. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Add endpoint for user specifying a key to use to sign metadata files

Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 9, 2019
@soapy1
Copy link
Contributor

soapy1 commented Oct 9, 2019

LGTM. Would be nice to sort out getting the authenticate module from conda before merging this in though

@awwad
Copy link
Author

awwad commented Oct 9, 2019

Definitely -- just wanted a sense of whether things made sense. TY.

@awwad awwad closed this Aug 18, 2020
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants