Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set build_platform for aid in cross compiling #4005

Merged
merged 2 commits into from Aug 19, 2020

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Aug 5, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 5, 2020
@isuruf
Copy link
Contributor Author

isuruf commented Aug 12, 2020

Ping @mingwandroid

@jjhelmus
Copy link
Contributor

Is the intention to have build_platform be a this be a pre-processor selector or an environment variable exported into the build environment?

This PR does the former but the later seems like a useful feature.

@isuruf
Copy link
Contributor Author

isuruf commented Aug 18, 2020

I wanted the former. For example along with #4011,

package:
  name: icu
requirements:
  build:
    - icu    # [build_platform != target_platform]
  run:
  host:

I can add this as a environment variable too.

@jjhelmus
Copy link
Contributor

Thanks @isuruf. These will need to be added to the docs at some point. I created #4018 for this.

@jjhelmus jjhelmus merged commit 7ae7bd5 into conda:master Aug 19, 2020
@isuruf isuruf deleted the build_platform branch August 19, 2020 20:40
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants