Also rewrite long prefix paths in output scripts $PREFIX, etc.
#4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
|
Test failed with flakiness |
mariusvniekerk
force-pushed
the
rewrite_env-in-outputs
branch
from
d381849
to
34ce292
Compare
mariusvniekerk
force-pushed
the
rewrite_env-in-outputs
branch
from
f11ed89
to
c275cbb
Compare
Whilst the intention initially was for ouput scripts to mostly do bundling it has emerged as a rather common pattern for recipes to not have a base recipe at all and the main build work is done in an output script. As a result of this use case, output scripts should have the same filtering applied to them as build scripts
mariusvniekerk
force-pushed
the
rewrite_env-in-outputs
branch
from
c275cbb
to
4d4d691
Compare
|
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
1 similar comment
|
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
github-actions
bot
added
the
stale::closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the intention initially was for ouput scripts to mostly do bundling it has emerged as a rather common pattern for recipes to not have a base recipe at all and the main build work is done in an output script.
As a result of this use case, output scripts should have the same filtering applied to them as build scripts
Example: https://github.com/conda-forge/arrow-cpp-feedstock/blob/main/recipe/meta.yaml