Add emscripten-wasm32 and wasi-wasm32 support #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
6 tasks
wolfv
force-pushed
the
emscripten-32
branch
from
6880e03
to
dda3919
Compare
jezdez
previously approved these changes
Sep 13, 2023
jezdez
changed the title
jezdez
previously approved these changes
Sep 13, 2023
isuruf
reviewed
Sep 20, 2023
isuruf
reviewed
Sep 20, 2023
isuruf
reviewed
Sep 20, 2023
jezdez
approved these changes
Sep 22, 2023
isuruf
reviewed
Oct 16, 2023
| @@ -580,7 +580,7 @@ def get_shlib_ext(host_platform): | |||
| return ".dll" | |||
| elif host_platform in ["osx", "darwin"]: | |||
| return ".dylib" | |||
| elif host_platform.startswith("linux"): | |||
| elif host_platform.startswith("linux") or host_platform.endswith("-wasm32"): | |||
There was a problem hiding this comment.
host_platform only has the OS, so this condition will not be true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need emscripten-wasm32 and wasi-wasm32 platform support in
emscripten-forge. Refs conda/conda#13095.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?