Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay imports in command plugin #4953

Merged
merged 4 commits into from
Aug 4, 2023
Merged

delay imports in command plugin #4953

merged 4 commits into from
Aug 4, 2023

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Jul 28, 2023

Description

Fix #4949 (avoid conda-build side effects when not using conda-build subcommands). Should improve conda start time when conda-build is installed.

Untested.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 28, 2023
@dholth dholth requested a review from kenodegard July 28, 2023 19:52
@@ -12,5 +12,6 @@
"index",
"inspect",
"metapackage",
"render" "skeleton",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Do we use this list?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess not?

@kenodegard
Copy link
Contributor

pre-commit.ci autofix

@dholth dholth enabled auto-merge (squash) August 2, 2023 14:36
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this locally and this change prevents the debugging messages from occurring for non-conda-build subcommands

@dholth dholth merged commit afe931a into main Aug 4, 2023
24 checks passed
@dholth dholth deleted the improved-command-plugin branch August 4, 2023 18:52
@dholth dholth mentioned this pull request Aug 17, 2023
14 tasks
@kenodegard kenodegard mentioned this pull request Sep 26, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DEBUG:urllib3.connectionpool enabled by default without invoking conda-build
3 participants