Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda#5708 cleanup #5031

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Oct 9, 2023

Description

Attempting to remove code marked as unnecessary once conda/conda#5708 was merged.

This is part of a larger effort to remove usage of conda.models.dist.Dist and related backports present in conda exclusively for conda_build.

Xref conda/conda#13192

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 9, 2023
@kenodegard kenodegard self-assigned this Oct 9, 2023
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the original issue mentioned in the comment and it looks like it was dealt with, so the workaround mentioned here can indeed be removed.

To make sure we don't need it, one can take a look at this other comment: conda/conda#5770 (comment)

@kenodegard kenodegard merged commit d9bc44d into conda:main Oct 11, 2023
24 checks passed
@kenodegard kenodegard deleted the post-conda-5708-cleanup branch October 11, 2023 16:56
@kenodegard kenodegard mentioned this pull request Dec 1, 2023
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants