Relax package/version check for multi outputs
#5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
dholth
reviewed
Dec 5, 2023
kenodegard
force-pushed
the
fix-multi-outputs
branch
from
8f114a3
to
96c5d64
Compare
kenodegard
commented
Dec 6, 2023
Comment on lines
+415
to
+417
| @pytest.mark.skip( | ||
| reason="GitHub discontinued SVN, see https://github.com/conda/conda-build/issues/5098" | ||
| ) |
There was a problem hiding this comment.
GitHub has started the processes of turning off SVN support causing this tests to fail. Refactoring revealed unexpected surprises, so I've chosen to step back for this hotfix and temporarily bypass the failing test.
See #5098 for more.
jezdez
approved these changes
Dec 6, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correcting conda-build issues identified for multi-outputs where the version is undefined (conda-forge/admin-requests#890).
Leaving in the version checks in simple recipes but relaxes the requirements for recipes with multi-outputs.
Xref #5055
Resolves #5097
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?