only warn about build.script_env when splitting with --no-test #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
rather than unconditionally warning about a possibly irrelevant scenario
minrk
force-pushed
the
env-warning-relevant
branch
from
96ba3c6
to
f3a575e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than unconditionally warning about a possibly irrelevant scenario.
Description
Any time build.script_env is used produces a warning (one for each variable) that if you happen to split build and test with
--no-testyou should make sure the test env matches. The only way to avoid this warning is to never use build.script_env.This moves the warning to a single warning, displayed only if
--no-testis given. So in the vast majority of cases, no warning is produced.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?